Skip to content

Change scss form checked variables to css variables for easy overwrite checkbox color#41161

Open
FrancoJFerreyra wants to merge 1 commit intotwbs:mainfrom
FrancoJFerreyra:main-change-scss-form-checked-variables-to-css
Open

Change scss form checked variables to css variables for easy overwrite checkbox color#41161
FrancoJFerreyra wants to merge 1 commit intotwbs:mainfrom
FrancoJFerreyra:main-change-scss-form-checked-variables-to-css

Conversation

@FrancoJFerreyra
Copy link

@FrancoJFerreyra FrancoJFerreyra commented Jan 18, 2025

Description

Change the values ​​of the form checked variables from $form-check-input-checked-bg-color and $form-check-input-checked-border-color to --#{$prefix}form-check-input-checked -bg-color and --#{$prefix}form-check-input-checked-border-color) by adding these to the _root.scss and _form-check.scss file.

Motivation & Context

Resolve issue #41137. #41137

Type of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (non-breaking change)
  • Breaking change (fix or feature that would change existing functionality)

Checklist

  • I have read the contributing guidelines
  • My code follows the code style of the project (using npm run lint)
  • My change introduces changes to the documentation
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed

Live previews

No live preview

Related issues

Closes #41137

@FrancoJFerreyra FrancoJFerreyra requested a review from a team as a code owner January 18, 2025 07:14
@mdo mdo added this to v5.4.0 Apr 9, 2025
@github-project-automation github-project-automation bot moved this to Needs review in v5.4.0 Apr 9, 2025
…put-checked-bg-color and $form-check-input-checked-border-color to --#{$prefix}form-check-input-checked -bg-color and --#{$prefix}form-check-input-checked-border-color) by adding these to the _root.scss and _form-check.scss file.

Resolve issue twbs#41137. twbs#41137

- [ ] Bug fix (non-breaking change which fixes an issue)
- [x] New feature (non-breaking change which adds functionality)
- [ ] Refactoring (non-breaking change)
- [ ] Breaking change (fix or feature that would change existing functionality)

- [x] I have read the [contributing guidelines](https://github.com/twbs/bootstrap/blob/main/.github/CONTRIBUTING.md)
- [x] My code follows the code style of the project _(using `npm run lint`)_
- [ ] My change introduces changes to the documentation
- [ ] I have updated the documentation accordingly
- [ ] I have added tests to cover my changes
- [ ] All new and existing tests passed

  No live preview

  twbs#41137
@mdo mdo force-pushed the main-change-scss-form-checked-variables-to-css branch from 3833ecc to 1c8a284 Compare June 3, 2025 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Needs review

Development

Successfully merging this pull request may close these issues.

Allow setting .form-check-input:checked colors with CSS variables

1 participant