Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ADD CLI option for --install-deps #341

Merged
merged 2 commits into from
Jul 31, 2023
Merged

ADD CLI option for --install-deps #341

merged 2 commits into from
Jul 31, 2023

Conversation

mknorps
Copy link
Collaborator

@mknorps mknorps commented Jul 25, 2023 •
edited
Loading

In this PR, --install-deps option is exposet to the user. It is almost the last piece of puzzle to add installing dependencies in a temporal virtual environment as a dependenceny mapping resolver.

We are left with describing it in the documentation #282 .

I tested the --install-deps option in CLi and if the virtual environment contains a dependency it is not installed in the temporal environment 👍

@mknorps mknorps force-pushed the 266-add-mapping-options-to-cli-eg-install-deps branch 2 times, most recently from 88658db to f7f4267 Compare July 28, 2023 05:53
@mknorps mknorps added this to the Mapping strategy milestone Jul 28, 2023
@mknorps mknorps force-pushed the 266-add-mapping-options-to-cli-eg-install-deps branch from f7f4267 to 4644fcf Compare July 28, 2023 06:23
@mknorps mknorps changed the title WIP: ADD CLI option for --install-deps ADD CLI option for --install-deps Jul 28, 2023
@mknorps mknorps marked this pull request as ready for review July 28, 2023 06:37
@mknorps mknorps self-assigned this Jul 28, 2023
@mknorps mknorps linked an issue Jul 28, 2023 that may be closed by this pull request
Add mapping options to CLI (e.g. --install-deps) #266
Closed
jherland
jherland approved these changes Jul 31, 2023
View reviewed changes
Copy link
Member

@jherland jherland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor nitpicking on the README, and one inconsequential thing I did not understand in test_cmdline_options.

But this is good to go! 🚀

README.md Outdated Show resolved Hide resolved
fawltydeps/cli_parser.py Show resolved Hide resolved
tests/test_cmdline_options.py Show resolved Hide resolved
@mknorps mknorps force-pushed the 266-add-mapping-options-to-cli-eg-install-deps branch 2 times, most recently from ede42fd to 25c082d Compare July 31, 2023 15:51
@mknorps mknorps force-pushed the 266-add-mapping-options-to-cli-eg-install-deps branch from 25c082d to ee5a8c8 Compare July 31, 2023 17:31
@mknorps mknorps merged commit 9e8c66c into main Jul 31, 2023
23 checks passed
@mknorps mknorps deleted the 266-add-mapping-options-to-cli-eg-install-deps branch July 31, 2023 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jherland jherland jherland approved these changes

@Nour-Mws Nour-Mws Awaiting requested review from Nour-Mws

Assignees

@mknorps mknorps

Labels
None yet
Projects
None yet
Milestone
Mapping strategy
Development

Successfully merging this pull request may close these issues.

Add mapping options to CLI (e.g. --install-deps)
2 participants
@mknorps @jherland