Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Top PyPi packages experiment and execution speed improvement #428

Merged
merged 6 commits into from
May 14, 2024

Conversation

mknorps
Copy link
Collaborator

@mknorps mknorps commented Apr 23, 2024

This PR:

  • adds top PyPI packages experiment,
  • removes results from the repo
  • reduces constant declarations
  • improves execution speed by taking only the last commit on the main branch from the PyPi repository

@mknorps mknorps requested a review from zz1874 April 23, 2024 11:45
Copy link
Collaborator

@zz1874 zz1874 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!
I'm really happy that we can get rid of the heavy JSON results in this repo 👍 .
Ideally, I think we can combine biomedical_projects_experiment/experiment.py and top_1400_pypi_packages/experiment.py into one single experiment.py in the experiments/ folder, since most of the lines of them are the same. We can do it in a separate PR.

@mknorps mknorps requested a review from zz1874 April 24, 2024 15:31
@mknorps mknorps merged commit 86a8761 into pypi-experiment May 14, 2024
13 of 33 checks passed
@mknorps mknorps deleted the maria/pypi-experiment branch May 14, 2024 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants