environment.yml: Ignore editable self-dependencies #495
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Issue #494 highlights the use of "-e ./" (i.e. an editable self-dependency) in environment.yml files. We already work around these kinds of self-dependencies in pyproject.toml and pixi.toml files, and our requirements.txt parser automatically ignores any lines with pip options, hence environment.yml is the only(?) remaining dependency file format where we're not yet handling this. Fix that, by recognizing this case before we emit an unnecessary error message about it. In either case we continue parsing the remaining lines, so the actual behavior (except for the error message) does not need to change. Fixes #494.
jherland
force-pushed
the
jherland/ignore-editable-self-deps
branch
from
90bcaa2 to
f11fd28
Compare
layus
approved these changes
Jun 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #494 highlights the use of "-e ./" (i.e. an editable
self-dependency) in environment.yml files.
We already work around these kinds of self-dependencies in
pyproject.toml and pixi.toml files, and our requirements.txt parser
automatically ignores any lines with pip options, hence environment.yml
is the only(?) remaining dependency file format where we're not yet
handling this.
Fix that, by recognizing this case before we emit an unnecessary error
message about it. In either case we continue parsing the remaining
lines, so the actual behavior (except for the error message) does not
need to change.
Fixes #494.