Misc. small administrivia #496
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Should take care of Dependabot alert re. requests: https://github.com/tweag/FawltyDeps/security/dependabot/7
These popped up with the upgrade from ruff 0.11 to 0.12.
NixOS/nixpkgs#420483 is adding FawltyDeps to nixpkgs, but needs a way to disable tests that need network access. Although we have tried to isolate such tests with the "integration" mark, we have not been entirely successful: The local_pypi fixture isolates us from contacting PyPI directly, but it does so by setting up a local PyPI index with some pre-populated packages. These packages are grabbed from the pytest cache, but when that cache is missing, they are ultimately downloaded from PyPI's CDN (see tests/python_packages.toml and TarballPackage in tests/project_helpers.py for the details). Use a trick from pytest-dev/pytest#1368 to automatically mark all tests using the local_pypi fixture with a new "needs_network" pytest mark. This will allow the nixpkgs expression for FawltyDeps to more easily skip tests that need network access.
layus
approved these changes
Jul 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Various small bits and bobs collected over the last weeks. The last commit will allow the nixpkgs addition of FawltyDeps to skip tests that need network access in a cleaner way.
Commits:
poetry update"needs_network"pytest mark to tests usinglocal_pypifixture