Add opaque response type to MsgReplyObjIds
#28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Niols
approved these changes
Feb 14, 2025
| \item [\argfont{objectIds}] An opaque type returned by the server when asked for object ids. | ||
| It is not explicitely a list of $\argfont{id}$, because the server may want to add metadata to the ids, | ||
| and/or run a compression scheme to limit the size of its response. | ||
| \item [\argfont{responseToIds}] A function with type $\argfont{obejctIds} \rightarrow [\argfont{id}]$. |
There was a problem hiding this comment.
To be generic and have a chance to cover Tx-Submission, shouldn't it then be
objectIds -> [(id, size)]
?
Also typo: s/obejct/object/
|
|
||
| \item [\MsgRequestObjs{} {($[\argfont{id}]$)}] | ||
| The client requests objects by sending a list of object ids. | ||
| The total size of the corresponding objects MUST not be bigger than the size limit in bytes. | ||
| \niols{Or maybe a bit less; should we take into account the size of the boilerplate?} | ||
|
|
||
| \item [\MsgReplyObjs{} {($[\argfont{object}]$})] | ||
| \item [\MsgReplyObjs{} {($[\argfont{object}]$)}] |
There was a problem hiding this comment.
In fact, I'd even go for $( ... )$ to get the math parentheses. But then we should probably go for $\MsgReplyObjs{} ( ... )$ with a macro to create the right spacing after \MsgReplyObjs with eg. \mathop. Let's no go there :p
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.