Switch to a crane based build #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ErinvanderVeen
force-pushed
the
fenix-crane
branch
from
2e53a2d to
f87f8b9
Compare
yannham
approved these changes
Apr 2, 2024
| cyclonedx = pkgs.callPackage ./nix/cyclonedx.nix { }; | ||
| nixtract-cli = nixtract.defaultPackage.${system}; | ||
|
|
||
| # Here we start the crane stuff |
There was a problem hiding this comment.
I know I'm often that guy but.... not a very high entropy comment 😛
| src = crane-lib.cleanCargoSource (crane-lib.path ./.); | ||
| strictDeps = true; | ||
|
|
||
| cargoArtifacts = cargo-artifacts; |
There was a problem hiding this comment.
Although it seems to work in practice, the cyclic dependency between common-crane-args and cargo-artifacts looks a bit surprising at first.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switch from Naersk to Crane
Description
This PR removes Naersk in favour of Crane. There is no specific reason that we make this switch other than some additional flexibility.
Checklist
Checklist before merging:
[ ] CHANGELOG.md updated[ ] README.md up-to-date