-
Notifications
You must be signed in to change notification settings - Fork 3.9k
Init twenty-sdk package #12971
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Init twenty-sdk package #12971
Conversation
9f30f0c
to
768dc71
Compare
768dc71
to
ec124b7
Compare
🚀 Preview Environment Ready! Your preview environment is available at: http://bore.pub:55886 This environment will automatically shut down when the PR is closed or after 5 hours. |
…ain permissions Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Summary
Initializes a new twenty-sdk package in the monorepo, but contains several configuration inconsistencies and setup issues that need addressing.
- File paths in
project.json
incorrectly reference 'twenty-shared' instead of 'twenty-sdk' for sourceRoot, needs immediate correction - Jest configuration in
jest.config.ts
has incorrect displayName and problematic moduleNameMapper regex pattern - ESLint configuration in
.eslintrc.cjs
mistakenly references twenty-shared's TypeScript config files - Initial implementation in
src/index.ts
is overly simplistic with just anaddNum
function, needs proper SDK functionality - Coverage thresholds in Jest config are unrealistically set to 100%, should be adjusted for a new package
13 files reviewed, 9 comments
Edit PR Review Bot Settings | Greptile
"src/**/*.spec.ts", | ||
"src/**/*.spec.tsx", | ||
"src/**/*.test.ts", | ||
"src/**/*.test.tsx", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
syntax: Invalid trailing comma in array literal. Remove the comma after '"src/**/*.test.tsx"'
"src/**/*.test.tsx", | |
"src/**/*.test.tsx" |
@greptileai trigger |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Summary
Initializing a new SDK package in the Twenty monorepo with significant package configuration. A few structural items need attention:
- Node.js engine version mismatch between packages:
twenty-shared
requires Node^22.12.0
while other packages have different versions, needs alignment package.json
seems to be missing fortwenty-sdk
, which is crucial for defining package metadata, dependencies, and build configuration- CI workflow for SDK package should align with existing packages' preconstruct build process
- Package exports and entry points need to be defined similar to other packages (like
twenty-shared
) for consistency in the monorepo
Note: Consider copying the preconstruct configuration from twenty-shared
for consistent package builds across the monorepo.
4 files reviewed, no comments
Edit PR Review Bot Settings | Greptile
@prastoin it's a bit early to start the sdk, let's tackle the sync metadata and import work first, closing for now :) |
Introduction
Initializing the
twenty-sdk
packageContaining very low level dependency, basic testing from now and basic preconstruct configuration too