Skip to content

Init twenty-sdk package #12971

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 5 commits into from
Closed

Init twenty-sdk package #12971

wants to merge 5 commits into from

Conversation

prastoin
Copy link
Contributor

@prastoin prastoin commented Jun 30, 2025

Introduction

Initializing the twenty-sdk package
Containing very low level dependency, basic testing from now and basic preconstruct configuration too

@prastoin prastoin changed the title Init twenty-sdk package Init twenty-sdk package Jun 30, 2025
@prastoin prastoin force-pushed the init-twenty-sdk-package branch from 9f30f0c to 768dc71 Compare June 30, 2025 15:54
@prastoin prastoin force-pushed the init-twenty-sdk-package branch from 768dc71 to ec124b7 Compare June 30, 2025 15:54
Copy link
Contributor

github-actions bot commented Jun 30, 2025

🚀 Preview Environment Ready!

Your preview environment is available at: http://bore.pub:55886

This environment will automatically shut down when the PR is closed or after 5 hours.

@prastoin prastoin changed the title Init twenty-sdk package Init twenty-sdk package Jun 30, 2025
…ain permissions

Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
@prastoin prastoin marked this pull request as ready for review June 30, 2025 20:10
Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

Initializes a new twenty-sdk package in the monorepo, but contains several configuration inconsistencies and setup issues that need addressing.

  • File paths in project.json incorrectly reference 'twenty-shared' instead of 'twenty-sdk' for sourceRoot, needs immediate correction
  • Jest configuration in jest.config.ts has incorrect displayName and problematic moduleNameMapper regex pattern
  • ESLint configuration in .eslintrc.cjs mistakenly references twenty-shared's TypeScript config files
  • Initial implementation in src/index.ts is overly simplistic with just an addNum function, needs proper SDK functionality
  • Coverage thresholds in Jest config are unrealistically set to 100%, should be adjusted for a new package

13 files reviewed, 9 comments
Edit PR Review Bot Settings | Greptile

"src/**/*.spec.ts",
"src/**/*.spec.tsx",
"src/**/*.test.ts",
"src/**/*.test.tsx",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

syntax: Invalid trailing comma in array literal. Remove the comma after '"src/**/*.test.tsx"'

Suggested change
"src/**/*.test.tsx",
"src/**/*.test.tsx"

@prastoin
Copy link
Contributor Author

prastoin commented Jul 1, 2025

@greptileai trigger

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

Initializing a new SDK package in the Twenty monorepo with significant package configuration. A few structural items need attention:

  • Node.js engine version mismatch between packages: twenty-shared requires Node ^22.12.0 while other packages have different versions, needs alignment
  • package.json seems to be missing for twenty-sdk, which is crucial for defining package metadata, dependencies, and build configuration
  • CI workflow for SDK package should align with existing packages' preconstruct build process
  • Package exports and entry points need to be defined similar to other packages (like twenty-shared) for consistency in the monorepo

Note: Consider copying the preconstruct configuration from twenty-shared for consistent package builds across the monorepo.

4 files reviewed, no comments
Edit PR Review Bot Settings | Greptile

@charlesBochet
Copy link
Member

@prastoin it's a bit early to start the sdk, let's tackle the sync metadata and import work first, closing for now :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants