Add Import CSV and Export CSV Permissions #13421
Merged
+118
−71
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Introduced new permission flags for importing and exporting CSV files in the PermissionFlagType enum. - Updated relevant components to check for these permissions before rendering export/import actions. - Enhanced the SettingsRolePermissionsToolSection to include options for managing CSV permissions. This change improves the role-based access control for CSV operations in the application.
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
Greptile Summary
This PR implements granular permission controls for CSV import and export functionality across the Twenty CRM application. The changes add two new permission flags (IMPORT_CSV and EXPORT_CSV) to the existing role-based permission system, allowing administrators to control which users can import data from CSV files or export data to CSV files.
The implementation follows the established permissions architecture by:
- Adding the new permission flags to the backend constants and services with secure defaults (disabled by default)
- Updating the frontend GraphQL generated types to include the new permission flags
- Integrating permission checks into existing action components using the
useHasSettingsPermissionhook - Adding UI configuration for these permissions in the settings panel under the "Actions" section
The changes affect multiple layers of the application: the backend permission service sets secure defaults, the frontend action components (ExportMultipleRecordsAction, ExportSingleRecordAction, ImportRecordsNoSelectionRecordAction) now conditionally render based on user permissions, and the settings UI allows administrators to configure these permissions per role. This follows the principle of least privilege by defaulting new permissions to false and requiring explicit granting of access.
Confidence score: 5/5
- This PR is extremely safe to merge with minimal risk of production issues
- The implementation follows established patterns consistently across all modified files and maintains backward compatibility
- No files need additional attention as the changes are straightforward permission additions with proper security defaults
8 files reviewed, 1 comment
...gs/roles/role-permissions/permission-flags/components/SettingsRolePermissionsToolSection.tsx
Outdated
Show resolved
Hide resolved
📊 API Changes ReportGraphQL Schema ChangesGraphQL Schema Changes[log] [log] ✖ Field settingsPermissions was removed from object type UserWorkspace GraphQL Metadata Schema ChangesGraphQL Metadata Schema Changes[log] [log] ✖ Field settingsPermissions was removed from object type UserWorkspace REST Metadata API Analysis ErrorError Output
|
|
🚀 Preview Environment Ready! Your preview environment is available at: http://bore.pub:36648 This environment will automatically shut down when the PR is closed or after 5 hours. |
- Introduced a new constants file for tool permission flags, including 'SEND_EMAIL_TOOL', 'IMPORT_CSV', and 'EXPORT_CSV'. - Updated the PermissionsService to incorporate tool permissions, allowing for more granular access control based on the new flags. - Refactored permission checking logic to utilize the new tool permission flags, improving the overall role-based access control system.
...tion-menu/actions/record-actions/multiple-records/components/ExportMultipleRecordsAction.tsx
Outdated
Show resolved
Hide resolved
...gs/roles/role-permissions/permission-flags/components/SettingsRolePermissionsToolSection.tsx
Outdated
Show resolved
Hide resolved
...tion-menu/actions/record-actions/multiple-records/components/ExportMultipleRecordsAction.tsx
Outdated
Show resolved
Hide resolved
- Added `requiredPermissionFlag` to action configurations for CSV import and export actions. - Updated `useRegisteredActions` hook to filter actions based on the new permission flags. - Imported `PermissionFlagType` to manage permissions effectively. This change improves role-based access control for CSV operations in the action menu.
…with `useHasPermissionFlag` in relevant components - Updated `useRecordGroupActions` and `SettingsProtectedRouteWrapper` to utilize the new permission hook. - Introduced `useHasPermissionFlag` to centralize permission checks based on permission flags, enhancing role-based access control.
… with `permissionFlags`
|
Thanks @abdulrahmancodes for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.