Add upgrade enqueue enum V2 command #13422
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
Greptile Summary
This PR introduces a V2 version of the AddEnqueuedStatusToWorkflowRunCommand to address a workspace-specific field metadata query issue in the original command. The changes create a new command file 1-2-add-enqueued-status-to-workflow-run-v2.command.ts that duplicates the existing command but adds two critical improvements:
- Workspace-specific object metadata retrieval: The V2 command first fetches the
workflowRunobject metadata for the specific workspace using the workspace ID and standard object ID - Scoped field metadata query: It then uses the retrieved object metadata ID when querying for the status field metadata, ensuring the query is properly scoped to the workspace
The original command had a potential bug where it queried field metadata using only the standardId without workspace filtering, which could return incorrect field metadata in multi-workspace scenarios. The V2 command fixes this by adding the objectMetadataId constraint to the field metadata query.
The command is integrated into the version 1.2 upgrade process by:
- Adding it to the
1-2-upgrade-version-command.module.tswith necessary dependencies (FieldMetadataEntity,ObjectMetadataEntity,WorkspaceDataSourceModule) - Registering it in the main
upgrade.command.tsfile and adding it to thebeforeSyncMetadataexecution list for version 1.2.0
This approach maintains backward compatibility while ensuring that the 1.2 upgrade correctly handles workspace-specific field metadata operations when adding the ENQUEUED status to workflow run status fields.
Confidence score: 4/5
- This is a targeted bug fix that addresses a specific workspace scoping issue in field metadata queries
- The implementation follows established patterns in the codebase for workspace-specific operations
- The files that need more attention are the new V2 command file and the module registration, as they contain the core logic changes
3 files reviewed, no comments
📊 API Changes ReportREST Metadata API Analysis ErrorError Output |
|
🚀 Preview Environment Ready! Your preview environment is available at: http://bore.pub:59379 This environment will automatically shut down when the PR is closed or after 5 hours. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Duplicated the existing command
AddEnqueuedStatusToWorkflowRunCommand. Adding two steps:workflowRunobject of the selected workspace