feat: added workspace member filter for actor fields #16628

abk404 · 2025-12-17T14:33:32Z

This PR adds support for filtering ACTOR fields by Workspace Member subfield, enabling users to filter records by who created them with a Me option.

I replicated the same UX and code structure as the Relation field filter for consistency.

Each filter selection triggers a server-side GraphQL call. But there is client-side filtering in isRecordMatchingFilter.ts which instantly filters already-loaded records while the server is fetching new results. I replicated this behaviour from how FULL_NAME and other composite fields handle filtering.

UX decision that were taken by me (Let me know if changes are needed) :

The filter shows comma separated selected workspace member names until 3 members are selected. After that it shows [no of selected members] workspace members.

greptile-apps

Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.

cubic-dev-ai

1 issue found across 11 files

Prompt for AI agents (all 1 issues)


Check if these issues are valid — if so, understand the root cause of each and fix them.


<file name="packages/twenty-front/src/modules/object-record/object-filter-dropdown/components/ObjectFilterDropdownActorSelect.tsx">

<violation number="1" location="packages/twenty-front/src/modules/object-record/object-filter-dropdown/components/ObjectFilterDropdownActorSelect.tsx:49">
P2: Duplicate schema parsing: both `isCurrentWorkspaceMemberSelected` and `selectedRecordIds` are extracted from the same value using identical parsing logic. Combine these into a single parse call to avoid redundant processing.</violation>
</file>

_{Reply to cubic to teach it or ask questions. Re-run a review with @cubic-dev-ai review this PR}

cubic-dev-ai · 2025-12-17T14:37:47Z

.../modules/object-record/object-filter-dropdown/components/ObjectFilterDropdownActorSelect.tsx

+    objectFilterDropdownSearchInputComponentState,
+  );
+
+  const { isCurrentWorkspaceMemberSelected } = jsonRelationFilterValueSchema


P2: Duplicate schema parsing: both isCurrentWorkspaceMemberSelected and selectedRecordIds are extracted from the same value using identical parsing logic. Combine these into a single parse call to avoid redundant processing.

Prompt for AI agents

Check if this issue is valid — if so, understand the root cause and fix it. At packages/twenty-front/src/modules/object-record/object-filter-dropdown/components/ObjectFilterDropdownActorSelect.tsx, line 49: <comment>Duplicate schema parsing: both `isCurrentWorkspaceMemberSelected` and `selectedRecordIds` are extracted from the same value using identical parsing logic. Combine these into a single parse call to avoid redundant processing.</comment> <file context> @@ -0,0 +1,185 @@ + objectFilterDropdownSearchInputComponentState, + ); + + const { isCurrentWorkspaceMemberSelected } = jsonRelationFilterValueSchema + .catch({ + isCurrentWorkspaceMemberSelected: false, </file context>

Copilot

Pull request overview

This PR adds support for filtering ACTOR fields by the Workspace Member subfield, enabling users to filter records by who created them with a "Me" option to quickly filter by the current user.

Added workspaceMemberId as a filterable subfield for ACTOR type fields
Implemented workspace member selection UI with a "Me" option for filtering by current user
Extended filter transformation logic to handle workspace member ID filtering with IS and IS_NOT operands

Reviewed changes

Copilot reviewed 11 out of 11 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
`packages/twenty-shared/src/types/RecordGqlOperationFilter.ts`	Added `workspaceMemberId` to `ActorFilter` type to support filtering by workspace member
`packages/twenty-shared/src/utils/filter/turnRecordFilterIntoGqlOperationFilter.ts`	Implemented filter transformation logic for `workspaceMemberId` subfield with support for IS and IS_NOT operands
`packages/twenty-front/src/modules/settings/data-model/constants/SettingsCompositeFieldTypeConfigs.ts`	Enabled `isFilterable: true` for the `workspaceMemberId` subfield of ACTOR fields
`packages/twenty-front/src/modules/settings/data-model/constants/CompositeFieldSubFieldLabel.ts`	Updated label from "Workspace Member ID" to "Workspace Member" for better UX
`packages/twenty-front/src/modules/object-record/record-filter/utils/isRecordMatchingFilter.ts`	Added client-side filter matching logic for workspace member ID
`packages/twenty-front/src/modules/object-record/record-filter/utils/getRecordFilterOperands.ts`	Added workspace member subfield detection and appropriate operands (IS, IS_NOT, empty operands)
`packages/twenty-front/src/modules/object-record/record-filter/constants/IconNameBySubField.ts`	Added icon mapping for workspace member subfield
`packages/twenty-front/src/modules/object-record/object-filter-dropdown/utils/isFilterOnActorWorkspaceMemberSubField.ts`	New utility function to detect workspace member subfield filters
`packages/twenty-front/src/modules/object-record/object-filter-dropdown/utils/getSubMenuOptions.ts`	Added "Workspace Member" option to ACTOR field submenu
`packages/twenty-front/src/modules/object-record/object-filter-dropdown/components/ObjectFilterDropdownActorSelect.tsx`	New component implementing workspace member selection with "Me" option and multi-select capability
`packages/twenty-front/src/modules/object-record/advanced-filter/components/AdvancedFilterDropdownFilterInput.tsx`	Integrated workspace member filter component into advanced filter dropdown

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2025-12-17T14:38:39Z

.../modules/object-record/object-filter-dropdown/components/ObjectFilterDropdownActorSelect.tsx

+  const { isCurrentWorkspaceMemberSelected } = jsonRelationFilterValueSchema
+    .catch({
+      isCurrentWorkspaceMemberSelected: false,
+      selectedRecordIds: arrayOfUuidOrVariableSchema.parse(
+        objectFilterDropdownFilterValue,
+      ),
+    })
+    .parse(objectFilterDropdownFilterValue);
+
+  const { selectedRecordIds } = jsonRelationFilterValueSchema
+    .catch({
+      isCurrentWorkspaceMemberSelected: false,
+      selectedRecordIds: arrayOfUuidOrVariableSchema.parse(
+        objectFilterDropdownFilterValue,
+      ),
+    })
+    .parse(objectFilterDropdownFilterValue);


The same schema is being parsed twice to extract different fields. This is inefficient and could lead to inconsistencies. Consider parsing once and destructuring both isCurrentWorkspaceMemberSelected and selectedRecordIds from the single parse result.

makes sense. Fixed.

packages/twenty-shared/src/utils/filter/turnRecordFilterIntoGqlOperationFilter.ts

+        const workspaceMemberIds = isCurrentWorkspaceMemberSelected
+          ? [
+              ...selectedRecordIds,
+              filterValueDependencies?.currentWorkspaceMemberId,
+            ].filter(isDefined)
+          : selectedRecordIds;


abk404 · 2025-12-17T23:00:11Z

@Bonapara Can I get a review here ?

Bonapara · 2025-12-18T08:43:01Z

The team is gonna review it very soon

lucasbordeau · 2026-01-14T18:05:14Z

Hi @abk404 sorry for the review delay.

That's a very nice PR overall, great work.

I made some minor modifications while testing it properly that I've pushed.

Here are still things to handle for this new filter to work :

Add it to the graph filter part :

@Bonapara should we add back the created by field in workflows ?

Issues: twentyhq#16619

github-actions · 2026-01-14T18:19:10Z

🚀 Preview Environment Ready!

Your preview environment is available at: http://bore.pub:59360

This environment will automatically shut down when the PR is closed or after 5 hours.

Copilot AI review requested due to automatic review settings December 17, 2025 14:33

greptile-apps bot reviewed Dec 17, 2025

View reviewed changes

Copilot started reviewing on behalf of abk404 December 17, 2025 14:34 View session

cubic-dev-ai bot reviewed Dec 17, 2025

View reviewed changes

Copilot AI reviewed Dec 17, 2025

View reviewed changes

abk404 force-pushed the add_workspace_member_actor_filter branch from 713b5da to c125421 Compare December 17, 2025 14:45

sentry bot reviewed Dec 17, 2025

View reviewed changes

abk404 force-pushed the add_workspace_member_actor_filter branch from c125421 to 43a91c8 Compare December 17, 2025 14:47

lucasbordeau self-assigned this Dec 29, 2025

charlesBochet added the -PR: awaiting review label Jan 8, 2026

lucasbordeau added -PR: awaiting author and removed -PR: awaiting review labels Jan 14, 2026

abk404 and others added 2 commits January 14, 2026 19:06

feat: added workspace member filter for actor fields

3da9266

Issues: twentyhq#16619

Minor fixes

3aa6311

lucasbordeau force-pushed the add_workspace_member_actor_filter branch from 604b2af to 3aa6311 Compare January 14, 2026 18:08

lucasbordeau mentioned this pull request Jan 14, 2026

feat: add "Created by: Me" filter for ACTOR workspaceMemberId subfield #16639

Closed

5 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: added workspace member filter for actor fields #16628

feat: added workspace member filter for actor fields #16628

Uh oh!

abk404 commented Dec 17, 2025 •

edited

Loading

Uh oh!

greptile-apps bot left a comment

Uh oh!

cubic-dev-ai bot left a comment

Uh oh!

cubic-dev-ai bot Dec 17, 2025 •

edited

Loading

Uh oh!

abk404 Dec 17, 2025

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Dec 17, 2025

Uh oh!

abk404 Dec 17, 2025

Uh oh!

This comment was marked as outdated.

Uh oh!

abk404 commented Dec 17, 2025

Uh oh!

Bonapara commented Dec 18, 2025

Uh oh!

lucasbordeau commented Jan 14, 2026

Uh oh!

github-actions bot commented Jan 14, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

feat: added workspace member filter for actor fields #16628

Are you sure you want to change the base?

feat: added workspace member filter for actor fields #16628

Uh oh!

Conversation

abk404 commented Dec 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

greptile-apps bot left a comment

Choose a reason for hiding this comment

Uh oh!

cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

Uh oh!

cubic-dev-ai bot Dec 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

abk404 Dec 17, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Dec 17, 2025

Choose a reason for hiding this comment

Uh oh!

abk404 Dec 17, 2025

Choose a reason for hiding this comment

Uh oh!

This comment was marked as outdated.

Uh oh!

abk404 commented Dec 17, 2025

Uh oh!

Bonapara commented Dec 18, 2025

Uh oh!

lucasbordeau commented Jan 14, 2026

Uh oh!

github-actions bot commented Jan 14, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

abk404 commented Dec 17, 2025 •

edited

Loading

cubic-dev-ai bot Dec 17, 2025 •

edited

Loading