fix: record does not open in side panel after returning from fullscreen #17131
+37
−16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Introduced a check for the command menu's open state before processing navigation stack. - Updated logic to ensure that the current record ID is only retrieved when the command menu is open and reset navigation stack is not triggered. - Improved readability and maintainability of the code by restructuring conditional checks.
- Enhanced the handling of side panel closing events by introducing a check for the command menu's open and closing states. - Utilized Recoil's snapshot to conditionally deactivate the record table row only when the command menu is not active, improving the overall user experience and preventing unintended deactivations. - Refactored the side panel closing listener to use a callback for better state management.
- Renamed the deactivation handler for clarity and improved the logic to ensure record deactivation only occurs when the command menu is not open. - Introduced a microtask queue to check the command menu state after the current execution, enhancing the responsiveness of the side panel closing event. - Refactored the side panel closing listener to utilize the updated deactivation logic for better state management.
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Contributor
|
🚀 Preview Environment Ready! Your preview environment is available at: http://bore.pub:40449 This environment will automatically shut down when the PR is closed or after 5 hours. |
- Renamed the deactivation handler to improve clarity and better reflect its purpose. - Updated the logic to ensure that record deactivation occurs only when the command menu is closed, enhancing the user experience. - Adjusted the side panel closing listener to utilize the renamed handler for improved readability and maintainability.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #17089