Fix the rendering of notes from workflow triggering #17210

araj00 · 2026-01-17T03:04:12Z

Problem:
Using the markdown from a saved note/task as a template in workflow to create a new note does not show the created note/task correctly.

Root cause
The function where blocknote to markdown conversion fails for certain block types (custom/code blocks)

convertedMarkdown = isDefined(parsedValue.blocknote) ? await serverBlockNoteEditor.blocksToMarkdownLossy( JSON.parse(parsedValue.blocknote), ) : null;

This adds some extra slashes which were required to normalize redundant escapes: strips all slashes before newlines and collapses multi-escapes to a single slash at first place.

Changes
Normalized the redundant escapes generated in converted markdown so that converted block note can be generated correctly.

Fixes: #17171

...wenty-server/src/engine/core-modules/record-transformer/utils/transform-rich-text-v2.util.ts

greptile-apps · 2026-01-17T03:08:21Z

Greptile Summary

This PR fixes markdown rendering issues when workflow templates use notes/tasks by normalizing redundant escape sequences generated during BlockNote-to-markdown conversion.

Key Changes:

Added regex-based escape normalization after blocksToMarkdownLossy conversion
Fixed the transformation flow to use convertedMarkdown instead of parsedValue.markdown when converting back to BlockNote format
Swapped priority in return statement to prefer converted values over parsed values

Issues Found:

The regex pattern may remove backslashes before characters outside [ntr"'\n], potentially corrupting file paths, regex patterns, or other legitimate backslash usage
Missing semicolon after regex replacement statement
Missing trailing comma in return object
No test coverage for the escape normalization logic

Confidence Score: 3/5

This PR addresses the reported issue but the regex pattern may have unintended side effects on certain content types
The fix correctly addresses the core issue of redundant escapes from BlockNote conversion and fixes the transformation flow. However, the regex pattern could potentially corrupt content containing backslashes before characters outside the defined set (file paths, code blocks, etc.). The missing test coverage and syntax issues also reduce confidence.
The transform-rich-text-v2.util.ts file needs testing with various markdown content types to ensure the regex doesn't corrupt legitimate backslashes

Important Files Changed

Filename	Overview
packages/twenty-server/src/engine/core-modules/record-transformer/utils/transform-rich-text-v2.util.ts	Added regex-based escape normalization to fix markdown rendering issues from BlockNote conversion, but pattern may have unintended side effects on backslashes before non-special characters

Sequence Diagram

sequenceDiagram
    participant WF as Workflow Engine
    participant RT as RecordInputTransformer
    participant TRTV2 as transformRichTextV2Value
    participant BN as BlockNote ServerEditor
    participant DB as Database

    WF->>RT: Create note with markdown from template
    RT->>TRTV2: Transform rich text value
    
    TRTV2->>TRTV2: Parse input (string/object)
    TRTV2->>BN: blocksToMarkdownLossy(blocknote)
    BN-->>TRTV2: Markdown with redundant escapes
    
    Note over TRTV2: NEW: Normalize escapes<br/>Remove \\+([ntr"'\n])|\\+
    
    TRTV2->>TRTV2: Apply regex normalization
    TRTV2->>BN: tryParseMarkdownToBlocks(normalizedMarkdown)
    BN-->>TRTV2: Clean BlockNote structure
    
    TRTV2-->>RT: {markdown, blocknote}
    RT->>DB: Save note with normalized content
    DB-->>WF: Note created successfully

greptile-apps

_{1 file reviewed, 4 comments}

_{Edit Code Review Agent Settings | Greptile}

greptile-apps · 2026-01-17T03:08:19Z

...wenty-server/src/engine/core-modules/record-transformer/utils/transform-rich-text-v2.util.ts

+    convertedMarkdown = (convertedMarkdown as string)?.replace(
+      /\\+([ntr"'\n])|\\+/g,
+      (_: string, char: string) => (char ? (char === '\n' ? char : '\\' + char) : ''),
+    )


logic: The regex pattern /\\+([ntr"'\n])|\\+/g may have unintended side effects. The second alternative \\+ matches and removes all backslashes not followed by [ntr"'\n]. This could corrupt legitimate backslashes in content like file paths (C:\\Users\\), regex patterns in code blocks, or backslashes before other characters (e.g., \\x becomes x).

Test case: if markdown contains text\\more, it would become textmore.

Consider if this is the intended behavior or if backslashes before characters outside [ntr"'\n] should be preserved. Are there test cases with file paths, code blocks with regex, or other content containing backslashes that should be preserved?

Prompt To Fix With AI

This is a comment left during a code review. Path: packages/twenty-server/src/engine/core-modules/record-transformer/utils/transform-rich-text-v2.util.ts Line: 52:55 Comment: **logic:** The regex pattern `/\\+([ntr"'\n])|\\+/g` may have unintended side effects. The second alternative `\\+` matches and **removes all backslashes** not followed by `[ntr"'\n]`. This could corrupt legitimate backslashes in content like file paths (`C:\\Users\\`), regex patterns in code blocks, or backslashes before other characters (e.g., `\\x` becomes `x`). Test case: if markdown contains `text\\more`, it would become `textmore`. Consider if this is the intended behavior or if backslashes before characters outside `[ntr"'\n]` should be preserved. Are there test cases with file paths, code blocks with regex, or other content containing backslashes that should be preserved? How can I resolve this? If you propose a fix, please make it concise.

greptile-apps · 2026-01-17T03:08:20Z

...wenty-server/src/engine/core-modules/record-transformer/utils/transform-rich-text-v2.util.ts

+    convertedMarkdown = (convertedMarkdown as string)?.replace(
+      /\\+([ntr"'\n])|\\+/g,
+      (_: string, char: string) => (char ? (char === '\n' ? char : '\\' + char) : ''),
+    )


syntax: Missing semicolon at end of statement

Suggested change

)

);

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

<details><summary>Prompt To Fix With AI</summary>

`````markdown

This is a comment left during a code review.

Path: packages/twenty-server/src/engine/core-modules/record-transformer/utils/transform-rich-text-v2.util.ts

Line: 55:55

Comment:

**syntax:** Missing semicolon at end of statement

```suggestion

);

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

How can I resolve this? If you propose a fix, please make it concise.

greptile-apps · 2026-01-17T03:08:20Z

...wenty-server/src/engine/core-modules/record-transformer/utils/transform-rich-text-v2.util.ts

+    convertedMarkdown = (convertedMarkdown as string)?.replace(
+      /\\+([ntr"'\n])|\\+/g,
+      (_: string, char: string) => (char ? (char === '\n' ? char : '\\' + char) : ''),
+    )


style: Consider adding tests for the escape normalization logic to ensure it handles edge cases correctly (file paths, code blocks, multiple backslashes, special characters)

Context Used: Context from dashboard - Always consider adding tests for new functionality, especially for edge cases like empty responses. (source)

_{Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!}

Prompt To Fix With AI

This is a comment left during a code review. Path: packages/twenty-server/src/engine/core-modules/record-transformer/utils/transform-rich-text-v2.util.ts Line: 52:55 Comment: **style:** Consider adding tests for the escape normalization logic to ensure it handles edge cases correctly (file paths, code blocks, multiple backslashes, special characters) **Context Used:** Context from `dashboard` - Always consider adding tests for new functionality, especially for edge cases like empty responses. ([source](https://app.greptile.com/review/custom-context?memory=458c2737-e49d-49c4-a233-2605d1516703)) Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time! How can I resolve this? If you propose a fix, please make it concise.

greptile-apps · 2026-01-17T03:08:21Z

...wenty-server/src/engine/core-modules/record-transformer/utils/transform-rich-text-v2.util.ts

-    markdown: parsedValue.markdown || convertedMarkdown,
-    blocknote: parsedValue.blocknote || convertedBlocknote,
+    markdown: convertedMarkdown || parsedValue.markdown,
+    blocknote: convertedBlocknote || parsedValue.blocknote


syntax: Missing comma at end of object property

Suggested change

blocknote: convertedBlocknote || parsedValue.blocknote

blocknote: convertedBlocknote || parsedValue.blocknote,

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

<details><summary>Prompt To Fix With AI</summary>

`````markdown

This is a comment left during a code review.

Path: packages/twenty-server/src/engine/core-modules/record-transformer/utils/transform-rich-text-v2.util.ts

Line: 78:78

Comment:

**syntax:** Missing comma at end of object property

```suggestion

blocknote: convertedBlocknote || parsedValue.blocknote,

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

How can I resolve this? If you propose a fix, please make it concise.

cubic-dev-ai

2 issues found across 1 file

Prompt for AI agents (all issues)


Check if these issues are valid — if so, understand the root cause of each and fix them.


<file name="packages/twenty-server/src/engine/core-modules/record-transformer/utils/transform-rich-text-v2.util.ts">

<violation number="1" location="packages/twenty-server/src/engine/core-modules/record-transformer/utils/transform-rich-text-v2.util.ts:53">
P1: Backslash normalization strips valid markdown content: any backslash not before n/t/r/"/'/newline is removed, corrupting escaped characters, paths, and code blocks.</violation>

<violation number="2" location="packages/twenty-server/src/engine/core-modules/record-transformer/utils/transform-rich-text-v2.util.ts:77">
P1: Conversion failures/lossy conversions now override original markdown/blocknote, risking corruption (catch assigns blocknote JSON to markdown and return prioritizes converted values).</violation>
</file>

_{Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.}

...wenty-server/src/engine/core-modules/record-transformer/utils/transform-rich-text-v2.util.ts

github-actions · 2026-01-17T03:15:30Z

🚀 Preview Environment Ready!

Your preview environment is available at: http://bore.pub:12391

This environment will automatically shut down when the PR is closed or after 5 hours.

...wenty-server/src/engine/core-modules/record-transformer/utils/transform-rich-text-v2.util.ts

cubic-dev-ai

1 issue found across 1 file (changes from recent commits).

Prompt for AI agents (all issues)


Check if these issues are valid — if so, understand the root cause of each and fix them.


<file name="packages/twenty-server/src/engine/core-modules/record-transformer/utils/transform-rich-text-v2.util.ts">

<violation number="1" location="packages/twenty-server/src/engine/core-modules/record-transformer/utils/transform-rich-text-v2.util.ts:59">
P2: Slash count includes following char, leaving extra backslashes for odd-length escape runs</violation>
</file>

_{Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.}

...wenty-server/src/engine/core-modules/record-transformer/utils/transform-rich-text-v2.util.ts

Fix the rendering of notes from workflow triggering

9ac5800

sentry bot reviewed Jan 17, 2026

View reviewed changes

...wenty-server/src/engine/core-modules/record-transformer/utils/transform-rich-text-v2.util.ts Outdated Show resolved Hide resolved

greptile-apps bot reviewed Jan 17, 2026

View reviewed changes

cubic-dev-ai bot reviewed Jan 17, 2026

View reviewed changes

...wenty-server/src/engine/core-modules/record-transformer/utils/transform-rich-text-v2.util.ts Show resolved Hide resolved

...wenty-server/src/engine/core-modules/record-transformer/utils/transform-rich-text-v2.util.ts Outdated Show resolved Hide resolved

Handle some edge case for the rich text

89985b5

sentry bot reviewed Jan 17, 2026

View reviewed changes

...wenty-server/src/engine/core-modules/record-transformer/utils/transform-rich-text-v2.util.ts Show resolved Hide resolved

cubic-dev-ai bot reviewed Jan 17, 2026

View reviewed changes

...wenty-server/src/engine/core-modules/record-transformer/utils/transform-rich-text-v2.util.ts Outdated Show resolved Hide resolved

araj00 added 2 commits January 17, 2026 10:59

Fixed the match length by excluding the char with multiple slash

fcdfd1c

Removed the irrelevant output.txt

f8f88f9

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix the rendering of notes from workflow triggering #17210

Fix the rendering of notes from workflow triggering #17210

Uh oh!

araj00 commented Jan 17, 2026 •

edited

Loading

Uh oh!

Uh oh!

greptile-apps bot commented Jan 17, 2026

Uh oh!

greptile-apps bot left a comment

Uh oh!

greptile-apps bot Jan 17, 2026

Uh oh!

greptile-apps bot Jan 17, 2026

Uh oh!

greptile-apps bot Jan 17, 2026

Uh oh!

greptile-apps bot Jan 17, 2026

Uh oh!

cubic-dev-ai bot left a comment

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Jan 17, 2026 •

edited

Loading

Uh oh!

Uh oh!

cubic-dev-ai bot left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

-    )
+    );
+<sub>Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!</sub>
+<details><summary>Prompt To Fix With AI</summary>
+`````markdown
+This is a comment left during a code review.
+Path: packages/twenty-server/src/engine/core-modules/record-transformer/utils/transform-rich-text-v2.util.ts
+Line: 55:55
+Comment:
+**syntax:** Missing semicolon at end of statement
+```suggestion
+    );
+<sub>Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!</sub>
+How can I resolve this? If you propose a fix, please make it concise.

Fix the rendering of notes from workflow triggering #17210

Are you sure you want to change the base?

Fix the rendering of notes from workflow triggering #17210

Uh oh!

Conversation

araj00 commented Jan 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

greptile-apps bot commented Jan 17, 2026

Greptile Summary

Confidence Score: 3/5

Important Files Changed

Sequence Diagram

Uh oh!

greptile-apps bot left a comment

Choose a reason for hiding this comment

Uh oh!

greptile-apps bot Jan 17, 2026

Choose a reason for hiding this comment

Uh oh!

greptile-apps bot Jan 17, 2026

Choose a reason for hiding this comment

Uh oh!

greptile-apps bot Jan 17, 2026

Choose a reason for hiding this comment

Uh oh!

greptile-apps bot Jan 17, 2026

Choose a reason for hiding this comment

Uh oh!

cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Jan 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

araj00 commented Jan 17, 2026 •

edited

Loading

github-actions bot commented Jan 17, 2026 •

edited

Loading