Fix redundant API calls when batch updating

packages/twenty-front/src/modules/object-record/hooks/__tests__/useIncrementalUpdateManyRecords.test.tsx

@@ -1,6 +1,7 @@
 import { useObjectMetadataItem } from '@/object-metadata/hooks/useObjectMetadataItem';
 import { useIncrementalFetchAndMutateRecords } from '@/object-record/hooks/useIncrementalFetchAndMutateRecords';
 import { useIncrementalUpdateManyRecords } from '@/object-record/hooks/useIncrementalUpdateManyRecords';
+import { useRefetchFindManyRecords } from '@/object-record/hooks/useRefetchFindManyRecords';
 import { useUpdateManyRecords } from '@/object-record/hooks/useUpdateManyRecords';
 import { dispatchObjectRecordOperationBrowserEvent } from '@/object-record/utils/dispatchObjectRecordOperationBrowserEvent';
 import { renderHook } from '@testing-library/react';
@@ -15,6 +16,9 @@ jest.mock('@/object-record/hooks/useRefetchAggregateQueries', () => ({
     refetchAggregateQueries: jest.fn(),
   }),
 }));
+jest.mock('@/object-record/hooks/useRefetchFindManyRecords', () => ({
+  useRefetchFindManyRecords: jest.fn(),
+}));
 jest.mock('@/object-record/hooks/useIncrementalFetchAndMutateRecords');
 
 const mockUseObjectMetadataItem = jest.mocked(useObjectMetadataItem);
@@ -25,6 +29,7 @@ const mockUseUpdateManyRecords = jest.mocked(useUpdateManyRecords);
 const mockUseIncrementalFetchAndMutateRecords = jest.mocked(
   useIncrementalFetchAndMutateRecords,
 );
+const mockUseRefetchFindManyRecords = jest.mocked(useRefetchFindManyRecords);
 
 describe('useIncrementalUpdateManyRecords', () => {
   const mockUpdateManyRecords = jest.fn();
@@ -53,6 +58,11 @@ describe('useIncrementalUpdateManyRecords', () => {
       updateProgress: mockUpdateProgress,
       cancel: jest.fn(),
     });
+
+    const mockRefetchFindManyRecords = jest.fn();
+    mockUseRefetchFindManyRecords.mockReturnValue({
+      refetchFindManyRecords: mockRefetchFindManyRecords,
+    });
   });
 
   it('should call incrementalFetchAndMutate and execute mutations via useUpdateManyRecords', async () => {
@@ -81,6 +91,7 @@ describe('useIncrementalUpdateManyRecords', () => {
       delayInMsBetweenRequests: 50,
       skipRegisterObjectOperation: true,
       skipRefetchAggregateQueries: true,
+      skipOptimisticEffect: true,
       abortSignal: expect.any(AbortSignal),
     });
     expect(mockUpdateProgress).toHaveBeenCalledWith(2, 2);
@@ -102,6 +113,9 @@ describe('useIncrementalUpdateManyRecords', () => {
         },
       },
     });
+
+    const { refetchFindManyRecords } = mockUseRefetchFindManyRecords.mock.results[0].value;
+    expect(refetchFindManyRecords).toHaveBeenCalled();
   });
 
   it('should pass abortSignal to updateManyRecords', async () => {

packages/twenty-front/src/modules/object-record/hooks/useIncrementalUpdateManyRecords.ts

@@ -3,6 +3,7 @@ import { DEFAULT_QUERY_PAGE_SIZE } from '@/object-record/constants/DefaultQueryP
 import { type UseFindManyRecordsParams } from '@/object-record/hooks/useFetchMoreRecordsWithPagination';
 import { useIncrementalFetchAndMutateRecords } from '@/object-record/hooks/useIncrementalFetchAndMutateRecords';
 import { useRefetchAggregateQueries } from '@/object-record/hooks/useRefetchAggregateQueries';
+import { useRefetchFindManyRecords } from '@/object-record/hooks/useRefetchFindManyRecords';
 import { useUpdateManyRecords } from '@/object-record/hooks/useUpdateManyRecords';
 import { type ObjectRecord } from '@/object-record/types/ObjectRecord';
 import { dispatchObjectRecordOperationBrowserEvent } from '@/object-record/utils/dispatchObjectRecordOperationBrowserEvent';
@@ -41,6 +42,10 @@ export const useIncrementalUpdateManyRecords = <
     objectMetadataNamePlural: objectMetadataItem.namePlural,
   });
 
+  const { refetchFindManyRecords } = useRefetchFindManyRecords({
+    objectMetadataNamePlural: objectMetadataItem.namePlural,
+  });
+
   const {
     incrementalFetchAndMutate,
     progress,
@@ -70,6 +75,7 @@ export const useIncrementalUpdateManyRecords = <
             delayInMsBetweenRequests: delayInMsBetweenMutations,
             skipRegisterObjectOperation: true,
             skipRefetchAggregateQueries: true,
+            skipOptimisticEffect: true,
             abortSignal,
           });
 
@@ -80,6 +86,7 @@ export const useIncrementalUpdateManyRecords = <
         },
       );
     } finally {
+      await refetchFindManyRecords();
       await refetchAggregateQueries();
 
       dispatchObjectRecordOperationBrowserEvent({

packages/twenty-front/src/modules/object-record/hooks/useRefetchFindManyRecords.ts

@@ -0,0 +1,24 @@
+import { useApolloCoreClient } from '@/object-metadata/hooks/useApolloCoreClient';
+import { capitalize } from 'twenty-shared/utils';
+
+export const useRefetchFindManyRecords = ({
+  objectMetadataNamePlural,
+}: {
+  objectMetadataNamePlural: string;
+}) => {
+  const apolloCoreClient = useApolloCoreClient();
+
+  const refetchFindManyRecords = async () => {
+    const findManyRecordsQueryName = `FindMany${capitalize(
+      objectMetadataNamePlural,
+    )}`;
+
+    await apolloCoreClient.refetchQueries({
+      include: [findManyRecordsQueryName],
+    });
+  };
+
+  return {
+    refetchFindManyRecords,
+  };
+};

packages/twenty-front/src/modules/object-record/record-update-multiple/hooks/useUpdateMultipleRecordsActions.ts

@@ -62,13 +62,8 @@ export const useUpdateMultipleRecordsActions = ({
     filter: graphqlFilter,
   });
 
-  const updateRecords = async (fieldsToUpdate: Record<string, any>) => {
-    const count = await incrementalUpdateManyRecords(fieldsToUpdate);
-    return count;
-  };
-
   return {
-    updateRecords,
+    updateRecords: incrementalUpdateManyRecords,
     isUpdating,
     progress,
     cancel,