fix: refresh virtualized table when field metadata is updated ( #16388 ) #17214

carbonFibreCode · 2026-01-17T12:31:42Z

Now we have used the metadata fetching from network using resetVirtualizationBecauseDataChanged(), as we navigate back to the table after updating the field content. As the virtualised table uses the "cache-first" strategy, it fails to give fresh data from the data base

Please let me know i we need to add the loading state (and it's UI requirements) while it fetches the cell content, as currently the cell is empty until it's populated by fresh data

Screen.Recording.2026-01-17.at.5.31.26.PM.mov

greptile-apps · 2026-01-17T12:39:12Z

Greptile Summary

Fixes virtualized table refresh issue where select field option updates weren't appearing in the table view due to cache-first strategy preventing fresh data display
Adds state management to track field metadata updates with timestamp-based detection, using lastFieldMetadataItemUpdateState and component-level tracking via lastProcessedFieldMetadataUpdateComponentState
Implements selective table refresh that only triggers resetVirtualizationBecauseDataChanged() when updated fields are visible in the current view, optimizing performance by avoiding unnecessary refreshes

Important Files Changed

Filename	Overview
packages/twenty-front/src/modules/object-metadata/hooks/useUpdateOneFieldMetadataItem.ts	Added state update to track field metadata changes with timestamp, field ID, and object ID for cache invalidation
packages/twenty-front/src/modules/object-record/record-table/virtualization/components/RecordTableVirtualizedInitialDataLoadEffect.tsx	Implemented field metadata update monitoring effect that selectively refreshes virtualized table when visible fields are updated

Confidence score: 4/5

This PR addresses a specific caching issue with a targeted solution that tracks field metadata updates and refreshes the virtualized table appropriately
Score reflects well-structured implementation with proper state management patterns, though the complexity of virtualization logic requires careful testing
Pay close attention to the effect implementation in RecordTableVirtualizedInitialDataLoadEffect.tsx to ensure proper dependency handling and prevent infinite re-renders

Sequence Diagram

sequenceDiagram
    participant User
    participant Frontend
    participant UpdateHook as "useUpdateOneFieldMetadataItem"
    participant GraphQL as "GraphQL API"
    participant MetadataRefresh as "refreshObjectMetadataItems"
    participant ViewRefresh as "refreshCoreViewsByObjectMetadataId"
    participant StateManager as "Recoil State"
    participant VirtualizedTable as "RecordTableVirtualizedInitialDataLoadEffect"
    participant ResetVirtualization as "resetVirtualizationBecauseDataChanged"

    User->>Frontend: "Update field metadata"
    Frontend->>UpdateHook: "updateOneFieldMetadataItem()"
    UpdateHook->>GraphQL: "updateOneFieldMetadataItemMutation()"
    GraphQL-->>UpdateHook: "Response"
    UpdateHook->>MetadataRefresh: "refreshObjectMetadataItems()"
    UpdateHook->>ViewRefresh: "refreshCoreViewsByObjectMetadataId()"
    UpdateHook->>StateManager: "setLastFieldMetadataItemUpdate()"
    
    VirtualizedTable->>StateManager: "Monitor lastFieldMetadataItemUpdate"
    StateManager-->>VirtualizedTable: "Field update detected"
    VirtualizedTable->>VirtualizedTable: "Check if field is in current view"
    VirtualizedTable->>ResetVirtualization: "resetVirtualizationBecauseDataChanged()"
    ResetVirtualization-->>VirtualizedTable: "Table refreshed"
    VirtualizedTable-->>Frontend: "Table displays updated field metadata"

greptile-apps · 2026-01-17T12:39:13Z

Greptile found no issues!

From now on, if a review finishes and we haven't found any issues, we will not post anything, but you can confirm that we reviewed your changes in the status check section.

_{This feature can be toggled off in your Code Review Settings by deselecting "Create a status check for each PR".}

github-actions · 2026-01-17T12:42:16Z

🚀 Preview Environment Ready!

Your preview environment is available at: http://bore.pub:57146

This environment will automatically shut down when the PR is closed or after 5 hours.

cubic-dev-ai

No issues found across 4 files

etiennejouan

Hi @carbonFibreCode, thank you so much for your contribution. I've tested it and it works well.

Concerning the implementation strategy, we plan to have an app-scoped state holding all sorts of metadata updates—a higher level one than the one you built.

Another issue I see: when first loading another table view based on another view showing the field, it would go through the useEffect (RecordTableVirtualizedInitialDataLoadEffect.tsx file), resetting virtualization when we don't need it to.

@lucasbordeau, what do you think? Would you have more precise guidance to help fix this? Or too complicated to fix without context/experience on twenty codebase ?

etiennejouan · 2026-01-19T09:32:27Z

...ecord/record-table/virtualization/components/RecordTableVirtualizedInitialDataLoadEffect.tsx

+    }
+
+    if (
+      lastFieldMetadataItemUpdate.timestamp === lastProcessedFieldMetadataUpdate


lastFieldMetadataItemUpdate.timestamp < lastProcessedFieldMetadataUpdate Shouldn't be more logic like that ?

carbonFibreCode · 2026-01-19T10:06:16Z

Hi @carbonFibreCode, thank you so much for your contribution. I've tested it and it works well.

Concerning the implementation strategy, we plan to have an app-scoped state holding all sorts of metadata updates—a higher level one than the one you built.

Another issue I see: when first loading another table view based on another view showing the field, it would go through the useEffect (RecordTableVirtualizedInitialDataLoadEffect.tsx file), resetting virtualization when we don't need it to.

@lucasbordeau, what do you think? Would you have more precise guidance to help fix this? Or too complicated to fix without context/experience on twenty codebase ?

hey @etiennejouan thanks for review, i am working on it right now to follow the implementation strategy for using appScoped state, open to @lucasbordeau 's comment
I'd prefer the guidance to get familiar with the codebase.

etiennejouan · 2026-01-19T12:26:47Z

Hi @carbonFibreCode, thank you so much for your contribution. I've tested it and it works well.
Concerning the implementation strategy, we plan to have an app-scoped state holding all sorts of metadata updates—a higher level one than the one you built.
Another issue I see: when first loading another table view based on another view showing the field, it would go through the useEffect (RecordTableVirtualizedInitialDataLoadEffect.tsx file), resetting virtualization when we don't need it to.
@lucasbordeau, what do you think? Would you have more precise guidance to help fix this? Or too complicated to fix without context/experience on twenty codebase ?

hey @etiennejouan thanks for review, i am working on it right now to follow the implementation strategy for using appScoped state, open to @lucasbordeau 's comment I'd prefer the guidance to get familiar with the codebase.

@carbonFibreCode
To make sure you don't work for nothing, I would wait wait for @lucasbordeau to get back.

carbonFibreCode · 2026-01-19T13:02:09Z

@carbonFibreCode To make sure you don't work for nothing, I would wait wait for @lucasbordeau to get back.

waiting for @lucasbordeau 's review,

In the mean time i tried switching to using a generic lastAppOperationState as requested, for the table refresh logic, I opted for a pure event driven approach, if a relevant event hasn't been processed by the component, we trigger a refresh.

lucasbordeau · 2026-01-19T14:14:09Z

...ecord/record-table/virtualization/components/RecordTableVirtualizedInitialDataLoadEffect.tsx

    visibleRecordFields,
  ]);

+  const lastFieldMetadataItemUpdate = useRecoilValue(


The logic works for me, could you just extract this into a separate effect component ? We try to keep one useEffect per component to avoid side effects that can happen when multiple useEffects share the same reactive dependencies.

Yeah sure, i'll do it and push the changes by 9:30 PM IST (4:30 PM CET) -> i hope correct about the time zone.. haha

Hi @lucasbordeau, I’ve updated the PR with the separate effect component as you suggested and all checks are passing. Would you mind having another look and sharing any further guidance, given the current blocked: tech spec needed label?

...-server/src/engine/workspace-manager/workspace-cleaner/services/cleaner.workspace-service.ts

lucasbordeau · 2026-01-21T14:22:45Z

packages/twenty-front/src/modules/object-metadata/states/lastFieldMetadataItemUpdateState.ts

@@ -0,0 +1,13 @@
+import { createState } from 'twenty-ui/utilities';
+
+export type LastFieldMetadataItemUpdate = {


Ok I think it's a good pattern :

The table updates only when it mounts back after settings change, so that's asynchronous as it should be

We reset virtualization as we already do for other update events, and it is designed to handle this frequently right now. (We would like to optimize those small state effects but that requires unlocking other improvements before.)

We already use this pattern elsewhere

Two changes though :

Could you use an uuid v4 instead of a timestamp for the referential integrity of this object ?

Extract this type in a standalone file

lucasbordeau · 2026-01-21T14:23:23Z

...-record/record-table/virtualization/states/lastProcessedFieldMetadataUpdateComponentState.ts

+import { ContextStoreComponentInstanceContext } from '@/context-store/states/contexts/ContextStoreComponentInstanceContext';
+import { createComponentState } from '@/ui/utilities/state/component-state/utils/createComponentState';
+
+export const lastProcessedFieldMetadataUpdateComponentState =


lastProcessedFieldMetadataUpdateIdComponentState => use an id property instead

lucasbordeau · 2026-01-21T14:23:50Z

...d/record-table/virtualization/components/RecordTableVirtualizedFieldMetadataUpdateEffect.tsx

+    }
+
+    if (
+      lastFieldMetadataItemUpdate.timestamp === lastProcessedFieldMetadataUpdate


Use id here for comparison

hmmmm.... ok

@lucasbordeau pushed the changes

now eventId is compared as per the request

pulled out the types in separate file as per existing design pattern

lucasbordeau

LGTM, nice contribution.

I've just added some minor renaming to make it more aligned with our conventions.

carbonFibreCode · 2026-01-22T15:05:29Z

LGTM, nice contribution.

I've just added some minor renaming to make it more aligned with our conventions.

Thanks for the feedback, Lucas, i've noted those naming conventions and will make sure to apply them to my future contributions. Appreciate the guidance on this one.

cubic-dev-ai bot reviewed Jan 17, 2026

View reviewed changes

etiennejouan self-assigned this Jan 19, 2026

etiennejouan reviewed Jan 19, 2026

View reviewed changes

etiennejouan added the blocked: tech spec needed label Jan 19, 2026

lucasbordeau reviewed Jan 19, 2026

View reviewed changes

carbonFibreCode requested a review from lucasbordeau January 19, 2026 15:11

sentry bot reviewed Jan 19, 2026

View reviewed changes

...-server/src/engine/workspace-manager/workspace-cleaner/services/cleaner.workspace-service.ts Show resolved Hide resolved

sentry bot reviewed Jan 19, 2026

View reviewed changes

...-server/src/engine/workspace-manager/workspace-cleaner/services/cleaner.workspace-service.ts Show resolved Hide resolved

carbonFibreCode force-pushed the fix/16388-select-field-label-table-refresh branch 4 times, most recently from dec4d06 to 45a3502 Compare January 19, 2026 18:36

etiennejouan added -PR: awaiting review and removed blocked: tech spec needed labels Jan 21, 2026

lucasbordeau reviewed Jan 21, 2026

View reviewed changes

lucasbordeau added -PR: awaiting author and removed -PR: awaiting review labels Jan 21, 2026

Fix: Add lastFieldMetadataItemUpdateState for select field refresh

9d6c673

carbonFibreCode force-pushed the fix/16388-select-field-label-table-refresh branch from 45a3502 to 9d6c673 Compare January 21, 2026 15:52

Fix: Add lastFieldMetadataItemUpdateState for select field refresh

c08ad9e

lucasbordeau added -PR: awaiting review and removed -PR: awaiting author labels Jan 22, 2026

lucasbordeau added 2 commits January 22, 2026 14:55

Merge branch 'main' into fix/16388-select-field-label-table-refresh

255817a

Minor fixes

a8147c3

lucasbordeau approved these changes Jan 22, 2026

View reviewed changes

lucasbordeau enabled auto-merge January 22, 2026 14:09

		@@ -0,0 +1,13 @@
		import { createState } from 'twenty-ui/utilities';

		export type LastFieldMetadataItemUpdate = {

fix: refresh virtualized table when field metadata is updated ( #16388 ) #17214

Are you sure you want to change the base?

fix: refresh virtualized table when field metadata is updated ( #16388 ) #17214

Conversation

carbonFibreCode commented Jan 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

greptile-apps bot commented Jan 17, 2026

Greptile Summary

Important Files Changed

Confidence score: 4/5

Sequence Diagram

Uh oh!

greptile-apps bot commented Jan 17, 2026

Greptile found no issues!

Uh oh!

github-actions bot commented Jan 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

Uh oh!

etiennejouan left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

carbonFibreCode commented Jan 19, 2026

Uh oh!

etiennejouan commented Jan 19, 2026

Uh oh!

carbonFibreCode commented Jan 19, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

lucasbordeau left a comment

Choose a reason for hiding this comment

Uh oh!

carbonFibreCode commented Jan 22, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

carbonFibreCode commented Jan 17, 2026 •

edited

Loading

github-actions bot commented Jan 17, 2026 •

edited

Loading

etiennejouan left a comment •

edited

Loading