-
Notifications
You must be signed in to change notification settings - Fork 5k
[Dashboards] Fix rich text widget empty side menu bug #17377
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This reverts commit 272ab8c.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No issues found across 1 file
Greptile SummaryFixed empty side menu bug when editing rich text widgets by adding
Confidence Score: 5/5
Important Files Changed
Sequence DiagramsequenceDiagram
participant User
participant Component
participant useEditPageLayoutWidget
participant CommandMenu
participant PageLayoutState
User->>Component: Click edit on rich text widget
Component->>useEditPageLayoutWidget: handleEditWidget({widgetId, widgetType: STANDALONE_RICH_TEXT})
useEditPageLayoutWidget->>PageLayoutState: setPageLayoutEditingWidgetId(widgetId)
alt widgetType === IFRAME
useEditPageLayoutWidget->>CommandMenu: navigatePageLayoutCommandMenu(iFrame settings)
useEditPageLayoutWidget-->>Component: return (early exit)
else widgetType === GRAPH
useEditPageLayoutWidget->>CommandMenu: navigatePageLayoutCommandMenu(graph settings)
useEditPageLayoutWidget-->>Component: return (early exit)
else other widget types (STANDALONE_RICH_TEXT, etc)
useEditPageLayoutWidget->>CommandMenu: closeCommandMenu()
Note over useEditPageLayoutWidget,CommandMenu: NEW: Closes empty side menu for unhandled types
useEditPageLayoutWidget-->>Component: return
end
|
|
🚀 Preview Environment Ready! Your preview environment is available at: http://bore.pub:7691 This environment will automatically shut down when the PR is closed or after 5 hours. |
|
Great! I will review tomorrow. Thank you. |
bosiraphael
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
Hey @ehconitin! After you've done the QA of your Pull Request, you can mark it as done here. Thank you! |
1 similar comment
|
Hey @ehconitin! After you've done the QA of your Pull Request, you can mark it as done here. Thank you! |
|
Thanks @ehconitin for your contribution! |

before -
CleanShot.2026-01-22.at.23.15.07.mp4
after -
CleanShot.2026-01-22.at.23.14.09.mp4