Skip to content

Conversation

@bosiraphael
Copy link
Contributor

Remove IS_PAGE_LAYOUT_ENABLED feature flag entirely

Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 10 files

@greptile-apps
Copy link
Contributor

greptile-apps bot commented Jan 23, 2026

Greptile Overview

Greptile Summary

This PR successfully removes the IS_PAGE_LAYOUT_ENABLED feature flag, making the dashboards feature available to all users by default.

Key changes:

  • Removed IS_PAGE_LAYOUT_ENABLED from FeatureFlagKey enum across frontend and backend
  • Eliminated conditional logic in useWorkspaceFavorites that filtered dashboard views based on feature flag
  • Removed FeatureFlagService dependency from OpenApiService and now always includes pageLayout metadata endpoints
  • Updated test cases to use IS_RECORD_PAGE_LAYOUT_ENABLED instead of the removed flag
  • Cleaned up seeding and test mocks that referenced the old flag
  • Deleted promotional image for the feature flag

The changes are clean and consistent across the codebase with no obvious issues.

Confidence Score: 5/5

  • This PR is safe to merge with minimal risk
  • The changes are straightforward and consistent - removing a feature flag to enable dashboards by default. All references to the flag have been properly cleaned up across frontend, backend, tests, and generated code. The test updates correctly reflect the new behavior.
  • No files require special attention

Important Files Changed

Filename Overview
packages/twenty-front/src/modules/favorites/hooks/useWorkspaceFavorites.ts Removed feature flag check and dashboard filtering logic, now includes all views unconditionally
packages/twenty-server/src/engine/core-modules/feature-flag/constants/public-feature-flag.const.ts Removed IS_PAGE_LAYOUT_ENABLED entry from PUBLIC_FEATURE_FLAGS array
packages/twenty-server/src/engine/core-modules/feature-flag/enums/feature-flag-key.enum.ts Removed IS_PAGE_LAYOUT_ENABLED from FeatureFlagKey enum
packages/twenty-server/src/engine/core-modules/open-api/open-api.service.ts Removed FeatureFlagService dependency and conditional pageLayout metadata inclusion, now always included

Sequence Diagram

sequenceDiagram
    participant Dev as Developer
    participant Enum as FeatureFlagKey Enum
    participant PublicFlags as Public Feature Flags
    participant OpenAPI as OpenAPI Service
    participant Frontend as Frontend Hook
    participant GraphQL as Generated GraphQL

    Note over Dev,GraphQL: Remove IS_PAGE_LAYOUT_ENABLED Feature Flag

    Dev->>Enum: Remove IS_PAGE_LAYOUT_ENABLED
    Dev->>PublicFlags: Remove dashboards config entry
    Dev->>OpenAPI: Remove FeatureFlagService dependency
    OpenAPI->>OpenAPI: Remove conditional pageLayout check
    OpenAPI->>OpenAPI: Always include pageLayout metadata

    Dev->>Frontend: Remove useFeatureFlagsMap hook
    Frontend->>Frontend: Remove dashboard filtering logic
    Frontend->>Frontend: Include all views unconditionally

    Dev->>GraphQL: Regenerate types (remove flag enum)
    
    Note over Dev,GraphQL: Dashboard feature now enabled by default
Loading

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No files reviewed, no comments

Edit Code Review Agent Settings | Greptile

@github-actions
Copy link
Contributor

github-actions bot commented Jan 23, 2026

🚀 Preview Environment Ready!

Your preview environment is available at: http://bore.pub:33330

This environment will automatically shut down when the PR is closed or after 5 hours.

@github-actions
Copy link
Contributor

📊 API Changes Report

GraphQL Schema Changes

GraphQL Schema Changes

[log]
Detected the following changes (1) between schemas:

[log] ✖ Enum value IS_PAGE_LAYOUT_ENABLED was removed from enum FeatureFlagKey
[error] Detected 1 breaking change
⚠️ Breaking changes or errors detected in GraphQL schema

[log] 
Detected the following changes (1) between schemas:

[log] ✖  Enum value IS_PAGE_LAYOUT_ENABLED was removed from enum FeatureFlagKey
[error] Detected 1 breaking change
Error generating diff

GraphQL Metadata Schema Changes

GraphQL Metadata Schema Changes

[log]
Detected the following changes (1) between schemas:

[log] ✖ Enum value IS_PAGE_LAYOUT_ENABLED was removed from enum FeatureFlagKey
[error] Detected 1 breaking change
⚠️ Breaking changes or errors detected in GraphQL metadata schema

[log] 
Detected the following changes (1) between schemas:

[log] ✖  Enum value IS_PAGE_LAYOUT_ENABLED was removed from enum FeatureFlagKey
[error] Detected 1 breaking change
Error generating diff

⚠️ Please review these API changes carefully before merging.

⚠️ Breaking Change Protocol

Breaking changes detected but PR title does not contain "breaking" - CI will pass but action needed.

🔄 Options:

  1. If this IS a breaking change: Add "breaking" to your PR title and add BREAKING CHANGE: to your commit message
  2. If this is NOT a breaking change: The API diff tool may have false positives - please review carefully

For breaking changes, add to commit message:

feat: add new API endpoint

BREAKING CHANGE: removed deprecated field from User schema

@bosiraphael bosiraphael added this pull request to the merge queue Jan 23, 2026
Merged via the queue into main with commit 78dd43d Jan 23, 2026
73 checks passed
@bosiraphael bosiraphael deleted the r--release-dashboards branch January 23, 2026 10:51
@twenty-eng-sync
Copy link

Hey @bosiraphael! After you've done the QA of your Pull Request, you can mark it as done here. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants