-
Notifications
You must be signed in to change notification settings - Fork 5k
Release dashboards V1 #17386
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release dashboards V1 #17386
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No issues found across 10 files
Greptile OverviewGreptile SummaryThis PR successfully removes the Key changes:
The changes are clean and consistent across the codebase with no obvious issues. Confidence Score: 5/5
Important Files Changed
Sequence DiagramsequenceDiagram
participant Dev as Developer
participant Enum as FeatureFlagKey Enum
participant PublicFlags as Public Feature Flags
participant OpenAPI as OpenAPI Service
participant Frontend as Frontend Hook
participant GraphQL as Generated GraphQL
Note over Dev,GraphQL: Remove IS_PAGE_LAYOUT_ENABLED Feature Flag
Dev->>Enum: Remove IS_PAGE_LAYOUT_ENABLED
Dev->>PublicFlags: Remove dashboards config entry
Dev->>OpenAPI: Remove FeatureFlagService dependency
OpenAPI->>OpenAPI: Remove conditional pageLayout check
OpenAPI->>OpenAPI: Always include pageLayout metadata
Dev->>Frontend: Remove useFeatureFlagsMap hook
Frontend->>Frontend: Remove dashboard filtering logic
Frontend->>Frontend: Include all views unconditionally
Dev->>GraphQL: Regenerate types (remove flag enum)
Note over Dev,GraphQL: Dashboard feature now enabled by default
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No files reviewed, no comments
|
🚀 Preview Environment Ready! Your preview environment is available at: http://bore.pub:33330 This environment will automatically shut down when the PR is closed or after 5 hours. |
📊 API Changes ReportGraphQL Schema ChangesGraphQL Schema Changes[log] [log] ✖ Enum value IS_PAGE_LAYOUT_ENABLED was removed from enum FeatureFlagKey GraphQL Metadata Schema ChangesGraphQL Metadata Schema Changes[log] [log] ✖ Enum value IS_PAGE_LAYOUT_ENABLED was removed from enum FeatureFlagKey
|
|
Hey @bosiraphael! After you've done the QA of your Pull Request, you can mark it as done here. Thank you! |
Remove
IS_PAGE_LAYOUT_ENABLEDfeature flag entirely