fix: Added keyboard functionality for esc and Ctrl + a #8282
+46
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
Implemented keyboard shortcuts for record selection in the drag select component, adding support for Ctrl/Cmd + A to select all records and Escape to deselect all records.
- Added keyboard event handler in
/packages/twenty-front/src/modules/ui/utilities/drag-select/components/DragSelect.tsxfor Ctrl/Cmd + A and Escape shortcuts - Uses
queueMicrotaskto handle selection changes asynchronously for better performance - Queries elements with
data-selectable-idattribute to manage record selection state - Prevents default browser behavior for both keyboard shortcuts to avoid conflicts
1 file(s) reviewed, 2 comment(s)
Edit PR Review Bot Settings | Greptile
Comment on lines
+58
to
+61
| useEffect(() => { | ||
| document.addEventListener('keydown', handleKeyDown); | ||
| return () => document.removeEventListener('keydown', handleKeyDown); | ||
| }, [handleKeyDown]); |
There was a problem hiding this comment.
style: Global event listener could interfere with other keyboard shortcuts when multiple DragSelect components are mounted. Consider using a more scoped approach or checking if the dragSelectable element is in focus.
packages/twenty-front/src/modules/ui/utilities/drag-select/components/DragSelect.tsx
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Pressing ⎋ on indexes should deselect all records #8247
Add ctrl + a to select all in index view #8206
Changes
Screen.Recording.2024-11-02.at.2.17.14.AM.mov