fix: Dropdown Overlapping Sidebar on Column Header Click in Horizontal Table When Scrolling #8287
+80
−30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…l Table When Scrolling
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR implements scroll state management to prevent dropdown menus from overlapping with the sidebar when scrolling horizontally in record tables.
- Added new
RecordTableScrollContextto control X/Y scrolling states - Implemented scroll disabling in
RecordTableColumnHeadWithDropdownwhen column header dropdown is opened - Modified
ScrollWrappercomponent to respectenableXScrollandenableYScrollprops from context - Enhanced
Dropdowncomponent to only close on Escape key when actually open - Added scroll state management in
RecordTableWithWrappersusing the new context provider
5 file(s) reviewed, 2 comment(s)
Edit PR Review Bot Settings | Greptile
...ges/twenty-front/src/modules/object-record/record-table/contexts/RecordTableScrollContext.ts
Show resolved
Hide resolved
Comment on lines
+31
to
+33
| setEnableXScroll(false); | ||
| setEnableYScroll(false); | ||
| }, [setEnableXScroll, setEnableYScroll]); |
There was a problem hiding this comment.
style: Consider only disabling X scroll since Y scroll is not related to the sidebar overlap issue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes : #8272