fix: Prevent isDisabled prop from passing to DOM in Settings/Security Link #8317
+4
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
Fixed React warning in Settings/Security tab by preventing invalid DOM attribute propagation.
- Added
shouldForwardPropoption toStyledLinkin/packages/twenty-front/src/modules/settings/security/components/SettingsSSOIdentitiesProvidersListCard.tsxto filter outisDisabledprop - Maintains existing disabled functionality through pointer-events CSS property
1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile
FelixMalfait
reviewed
Nov 6, 2024
| @@ -13,7 +13,9 @@ import styled from '@emotion/styled'; | |||
| import { useRecoilValue } from 'recoil'; | |||
| import { IconKey } from 'twenty-ui'; | |||
|
|
|||
| const StyledLink = styled(Link)<{ isDisabled: boolean }>` | |||
| const StyledLink = styled(Link, { | |||
| shouldForwardProp: (prop) => prop !== 'isDisabled', | |||
There was a problem hiding this comment.
Could you also add && isPropValid(prop) ? Thanks!
|
Thanks @harshrajeevsingh for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #8297