-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FIX] Text overflow on timeline #8325
base: main
Are you sure you want to change the base?
[FIX] Text overflow on timeline #8325
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Summary
This PR fixes text overflow issues in the timeline summary component by implementing proper width constraints and text truncation with ellipsis for long content.
- Added
width: 100%
toStyledSummary
in/packages/twenty-front/src/modules/activities/timeline-activities/components/EventRow.tsx
to prevent container expansion - Implemented text truncation in
/packages/twenty-front/src/modules/activities/timeline-activities/rows/activity/components/EventRowActivity.tsx
withtext-overflow: ellipsis
andwhite-space: nowrap
- Added
overflow: hidden
to prevent horizontal scrolling on long task titles and bodies
2 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings | Greptile
width: 100%; | ||
overflow: hidden; | ||
text-overflow: ellipsis; | ||
white-space: nowrap; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
style: Consider adding max-width property to ensure the text doesn't push other elements out of position
Is there a bug with the timeline? @Bonapara https://www.loom.com/share/de72e092dc024af89e27f0ff2d334ae3?sid=2b14e0f7-4731-4e33-a584-b180942388f0 The timeline doesn't show changes in local setup too... |
I had the same problem @Hitarthsheth07 but running the worker solved my issue: |
Gotcha! |
Did it work? |
Havent tried it yet! I'm travelling right now. Will get back to you in about an hour But why is it not working on the demo site then? |
FIX: #6977
Implementation:
text-overflow: ellipses
when overflown.