Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes: Standardize "Add New" button in dropdown menus #8169 #8353

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

prathameshpatil5181
Copy link

fixes #8169

fixtwenty.mp4

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

Standardized the "Add New" button placement in dropdown menus by moving it to a dedicated container section, improving UI consistency across single and multi-select dropdowns.

  • Moved CreateNewButton into its own DropdownMenuItemsContainer in SingleEntitySelectMenuItemsWithSearch.tsx
  • Added DropdownMenuSeparator to visually separate the "Add New" button from the list items
  • Integrated search filter with onCreate callback to support creating items with search text
  • Removed redundant showCreateButton prop since button visibility is now controlled by onCreate prop existence

1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile

Copy link

github-actions bot commented Nov 5, 2024

Welcome!

Hello there, congrats on your first PR! We're excited to have you contributing to this project.
By submitting your Pull Request, you acknowledge that you agree with the terms of our Contributor License Agreement.

Generated by 🚫 dangerJS against 4d443f5

@prathameshpatil5181
Copy link
Author

@Bonapara / @charlesBochet can you please review this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Standardize "Add New" button in dropdown menus
1 participant