fix: Fix constructor to properly retrieve capabilities values

[ibnsultan]

What kind of change does this PR introduce?

• Bugfix
• Feature
• Code style update
• Refactor
• Build-related changes
• Other, please describe below

Error Description

The original constructor incorrectly retrieved the mms and sms values due to case sensitivity in the array keys ('mms' and 'sms' instead of 'MMS' and 'SMS'). This resulted in default values being returned as "false" (a string) rather than false (a boolean), causing:

• Unexpected behavior in JSON serialization and comparisons.

• Direct retrieval of class items (e.g., getSMS, getMMS, etc.) always returned true because the methods were enforced to return :bool. Since the allocated value was a string, it was evaluated as true.

• Also the capabilities response does not include the fax status causing to always default to false

Fixed Issues Description

Updated the PhoneNumberCapabilities constructor to correctly retrieve the values for mms, sms, voice, and fax. The case-sensitive keys for MMS and SMS were changed to uppercase, and default values are now false instead of strings. This resolves the issue where incorrect values were being assigned to the capabilities properties.

Unfixed Issue Description

The fax value will still default to false because the capabilities response, whether retrieved through the SDK or the REST API, does not include the fax status. Therefore, even though the constructor attempts to retrieve fax, it will always be set to false.

Does this PR introduce a breaking change? (check one)

• Yes
• No

Related Issue

#783

Checklist

• I acknowledge that all my contributions will be made under the project's license
• I have made a material change to the repo (functionality, testing, spelling, grammar)
• I have read the Contribution Guidelines and my PR follows them
• I have titled the PR appropriately
• I have updated my branch with the main branch
• I have added tests that prove my fix is effective or that my feature works
• I have added the necessary documentation about the functionality in the appropriate .md file
• I have added inline documentation to the code I modified

If you have questions, please file a support ticket, or create a GitHub Issue in this repository.

[Shakerrry]

I have this issue too. Have you found an workaround until this is solved?

Update: I have implemented this workaround:

$capabilities = (array) $result->capabilities;
echo $capabilities["\x00*\x00sms"];

[ibnsultan]

@Shakerrry Not really other than the edit and locking the file from being overwritted from the package changes

[LukasKez]

Can we get some attention to this and get it released?

[tryvin]

for those who get here, until @twilio-dx takes some time to fix their own error, this might help, a composer post-autoload-dump:

"scripts": {
        "post-autoload-dump": [
            "sed -i.bak \"s/\\$capabilities, 'mms'/\\$capabilities, 'MMS'/g\" vendor/twilio/sdk/src/Twilio/Base/PhoneNumberCapabilities.php",
            "sed -i.bak \"s/\\$capabilities, 'sms'/\\$capabilities, 'SMS'/g\" vendor/twilio/sdk/src/Twilio/Base/PhoneNumberCapabilities.php",
            "sed -i.bak \"s/\\\"false\\\"/false/g\" vendor/twilio/sdk/src/Twilio/Base/PhoneNumberCapabilities.php"
        ]
}