Process ivar fields and friends when introspecting code (wrt C-modules)

[tristanlatr]

Fixes #903

@ntamas, this fixes the issue you reported lately.

The testing does not explicitely cover C-module, but I'm pretty confident this will do the trick.

If I understand correctly the initial problem, the ivar fields you were trying to use is just a workaround another issue in pydoctor, that is that property defined in C code are not recognized because they don't appear in the __dict__ attribute of classes. Maybe by using inspect.getmembers instead we could fix this issue as well? Tell me what you think, thanks.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.18%. Comparing base (c026873) to head (e7e6a58).
Report is 1 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #904      +/-   ##
==========================================
+ Coverage   93.14%   93.18%   +0.04%     
==========================================
  Files          47       47              
  Lines        8733     8736       +3     
  Branches     1600     1601       +1     
==========================================
+ Hits         8134     8141       +7     
+ Misses        338      336       -2     
+ Partials      261      259       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[github-actions]

According to pydoctor_primer, this change doesn't affect pydoctor warnings on a corpus of open source code. ✅

[ntamas]

I tested the igraph documentation with this PR and I can confirm that @ivar tags are now recognized properly in the docstring of a class defined in a C module so this can be merged.

At the same time, yes, you are correct, adding an @ivar in the Vertex and Edge classes of igraph is a workaround for the problem that getters/setters defined in a class of a C module are not processed by PyDoctor. They do appear in __dict__, but their value is of type getset_descriptor, which is not handled by any of the branches in _introspectThing:

>>> from igraph import Edge
>>> type(Edge.__dict__["index"])
<class 'getset_descriptor'>

[glyph]

I believe that this descriptor type is exposed publicly as types.GetSetDescriptorType .

[tristanlatr]

Many thanks for your inputs. I’ll look at supporting introspection of property-like types implemented in c extensions in the near future.