Skip to content

[pre-commit.ci] pre-commit autoupdate#732

Open
pre-commit-ci[bot] wants to merge 3 commits intotrunkfrom
pre-commit-ci-update-config
Open

[pre-commit.ci] pre-commit autoupdate#732
pre-commit-ci[bot] wants to merge 3 commits intotrunkfrom
pre-commit-ci-update-config

Conversation

@pre-commit-ci
Copy link
Contributor

@pre-commit-ci pre-commit-ci bot commented Feb 2, 2026

updates:
- [github.com/psf/black-pre-commit-mirror: 25.12.0 → 26.1.0](psf/black-pre-commit-mirror@25.12.0...26.1.0)
@pre-commit-ci pre-commit-ci bot requested a review from a team as a code owner February 2, 2026 19:58
Copy link
Member

@hynek hynek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yay new black style!

@hynek hynek self-requested a review February 3, 2026 07:56
@hynek
Copy link
Member

hynek commented Feb 3, 2026

ugh so this is kinda bad. Black seems to have decided that the correct number of empty lines after imports is 1 is wrong and clashes with our isort config. Unless they reconsider, I recommend switching to Ruff which I'm sure will have an option for this.

@pre-commit-ci pre-commit-ci bot force-pushed the pre-commit-ci-update-config branch from 67506ca to c7702be Compare March 2, 2026 20:42
@hynek
Copy link
Member

hynek commented Mar 3, 2026

So small update: I was gonna admit defeat as the only person caring about this style but unfortunately, switching isort to one line after imports triggers flake8's E302. So it looks like there's no way to have empty lines enforcement and black at the same time? I'm really, really, really sad about all this and reaching out through my backchannels did nothing so unless anyone has a better idea, I'll open a PR switching to Ruff.

@hynek hynek force-pushed the pre-commit-ci-update-config branch from 6aa5dcd to baff743 Compare March 8, 2026 12:02
@hynek
Copy link
Member

hynek commented Mar 8, 2026

based on @itamarst's suggestion on Mastodon I've just killed the flake8 switch and this is ready for review

@hynek hynek requested review from a team March 9, 2026 05:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant