Skip to content

[Issue-412]: use self.body for setting _SynchronousProducer length attribute #413

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 13, 2025

Conversation

ab-pilot
Copy link
Contributor

Resolves #412

These changes use the encoded body to set _SynchronousProducer length attribute instead of the input string.

Copy link
Member

@glyph glyph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Assuming tests are happy, let's land this.

@glyph glyph enabled auto-merge June 13, 2025 18:44
@glyph
Copy link
Member

glyph commented Jun 13, 2025

I snuck in a bit of reformatting with black while making the linter happy; we should probably do the whole codebase soon.

@glyph glyph merged commit 0b4247e into twisted:trunk Jun 13, 2025
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

StubTreq _SynchronousProducer does not use encoded body to set length.
2 participants