Cleanup header comments to be more clear and similar to the newer hea…

…ders by protobuf
twitchtv · Jun 16, 2021 · f2e3117 · f2e3117
1 parent d7e6923
commit f2e3117
Show file tree

Hide file tree

Showing 19 changed files with 64 additions and 182 deletions.
diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md
@@ -72,7 +72,7 @@ Twirp uses Github releases. To make a new release:
 
  1. Merge all changes that should be included in the release into the master branch.
  2. Update the version constant in `internal/gen/version.go`. Please respect [semantic versioning](http://semver.org/): `v<major>.<minor>.<patch>`.
- 3. Run `make generate` and run tests. Check that generated test files include a header comment with the new version.
+ 3. Run `make test_all` to re-generate code and run tests. Check that generated test files include the new version in the header comment.
  4. Add a new commit to master with a message like "Version vX.X.X release" and push.
  5. Tag the commit you just made: `git tag vX.X.X` and `git push origin --tags`.
  6. Go to Github https://github.com/twitchtv/twirp/releases and "Draft a new release".

diff --git a/clientcompat/internal/clientcompat/clientcompat.twirp.go b/clientcompat/internal/clientcompat/clientcompat.twirp.go
diff --git a/example/service.twirp.go b/example/service.twirp.go
diff --git a/internal/gen/version.go b/internal/gen/version.go
@@ -13,4 +13,4 @@
 
 package gen
 
-const Version = "v8.0.0"
+const Version = "v8.1.0"
diff --git a/internal/twirptest/empty_service/empty_service.twirp.go b/internal/twirptest/empty_service/empty_service.twirp.go
diff --git a/internal/twirptest/google_protobuf_imports/service.twirp.go b/internal/twirptest/google_protobuf_imports/service.twirp.go
diff --git a/internal/twirptest/importable/importable.twirp.go b/internal/twirptest/importable/importable.twirp.go
diff --git a/internal/twirptest/importer/importer.twirp.go b/internal/twirptest/importer/importer.twirp.go
diff --git a/internal/twirptest/importer_local/importer_local.twirp.go b/internal/twirptest/importer_local/importer_local.twirp.go
diff --git a/internal/twirptest/importmapping/x/x.twirp.go b/internal/twirptest/importmapping/x/x.twirp.go
diff --git a/internal/twirptest/json_serialization/json_serialization.twirp.go b/internal/twirptest/json_serialization/json_serialization.twirp.go
diff --git a/internal/twirptest/multiple/multiple1.twirp.go b/internal/twirptest/multiple/multiple1.twirp.go
diff --git a/internal/twirptest/multiple/multiple2.twirp.go b/internal/twirptest/multiple/multiple2.twirp.go
Original file line number	Diff line number	Diff line change
Expand Up		@@ -13,4 +13,4 @@

		package gen

		const Version = "v8.0.0"
		const Version = "v8.1.0"