Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Scala 3 support to build and CI matrix #949

Draft
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

felixbr
Copy link
Contributor

@felixbr felixbr commented May 18, 2023

Hi, this is early work on supporting a native Scala 3 build for Finagle.

The changes I've made are close to the current setup in twitter/util (including my PR there for Scala 3 CI).

Right now this only adds Scala 3 to finagle-init as a PoC because other modules are still blocked on twitter/util as far as I know.

I'm aware that many Finagle modules are already usable with Scala 3 projects using the cross-compilation (= .cross(CrossVersion.for3Use2_13)) feature. This works decently well for applications but is not a suitable solution for libraries which build on Finagle or more complex cross-building setups.

Note: Currently this branches from release not from develop because the latter seems to be unstable. I will rebase onto develop before converting the draft into a real PR ready to be merged.

@xin301x
Copy link

xin301x commented May 18, 2023 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants