Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change search input to type=search #148

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

coliff
Copy link
Contributor

@coliff coliff commented Oct 27, 2022

This change doesn't look different visually, but it is more semantically correct and allows the user to press ESC to clear the input for improved UX.

This looks the same but is more semantically correct and allows the user to press `ESC` to clear the input.
Copy link

@harshsingh32 harshsingh32 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants