WIP: Upgrade to libthrift 0.19.0 #367
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Scrooge's `TArrayByteTransport` and `TReusableMemoryTransport` classes both extend libthrift's abstract `org.apache.thrift.transport.TTransport` class. That class gained 3 new abstract members with apache/thrift#2191 (September 2020), released with libthrift v0.14.0 (February 2021). Consequently, both classes currently fail to compile, due to missing implementations for these methods: def checkReadBytesAvailable(x$1: Long): Unit = ??? def getConfiguration(): org.apache.thrift.TConfiguration = ??? def updateKnownMessageSize(x$1: Long): Unit = ??? Note that Snyk PR twitter#357 updates only one of several files that needs to be updated for a libthrift upgrade, and the most important file is probably `build.sbt`, not `demos/scrooge-maven-demo/pom.xml`.
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scrooge's
TArrayByteTransportandTReusableMemoryTransportclasses both extend libthrift's abstractorg.apache.thrift.transport.TTransportclass. That class gained 3 new abstract members with apache/thrift#2191 (September 2020), released with libthrift v0.14.0 (February 2021). Consequently, both classes currently fail to compile, due to missing implementations for these methods:Note that Snyk PR #357 updates only one of several files that needs to be updated for a libthrift upgrade, and the most important file is probably
build.sbt, notdemos/scrooge-maven-demo/pom.xml.