Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add monitor feature #653

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

Conversation

kukey
Copy link
Contributor

@kukey kukey commented Sep 22, 2021

implents #652

@CLAassistant
Copy link

CLAassistant commented Sep 23, 2021

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ kukey
❌ huangwei03


huangwei03 seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

Copy link
Collaborator

@TysonAndre TysonAndre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems promising and should have low impact when monitors are not used, but I had some review comments.

I'm also not that familiar with the redis monitor protocol and the edge cases, so I'll probably have more comments when I do look at that.

E.g. twemproxy should probably disconnect a client and assume the client is misbehaving if a command is sent by a client (with c->monitor true) before the client signals that the monitor should be stopped.

src/nc_monitor.h Outdated Show resolved Hide resolved
src/nc_string.c Outdated Show resolved Hide resolved
src/nc_string.c Outdated Show resolved Hide resolved
src/nc_monitor.c Outdated Show resolved Hide resolved
src/nc_monitor.c Outdated Show resolved Hide resolved
src/nc_rbtree.c Outdated Show resolved Hide resolved
src/nc_monitor.c Outdated Show resolved Hide resolved
src/nc_string.c Outdated Show resolved Hide resolved
src/nc_monitor.c Outdated Show resolved Hide resolved
src/nc_monitor.c Outdated Show resolved Hide resolved
@kukey
Copy link
Contributor Author

kukey commented Sep 27, 2021

@TysonAndre
I suddenly realized the need to add a security authentication mechanism to prevent disclosure of request information caused by monitor command.

@TysonAndre
Copy link
Collaborator

I suddenly realized the need to add a security authentication mechanism to prevent disclosure of request information caused by monitor command.

Also, it would be reasonable to have it be off by default in the pool config (nc_conf) - if nobody's actively using it or deciding to enable it the performance impact would be surprising when someone tried monitor

@kukey
Copy link
Contributor Author

kukey commented Oct 19, 2021

@TysonAndre please review

Copy link
Contributor Author

@kukey kukey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i review again, please give me some suggestion, thanks. @TysonAndre

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants