[Fixes #135] Updated chart to accept configPath to fix distribution's 3.0.0 breaking change #168
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Clovel
force-pushed
the
feature/config-path
branch
from
cd2b50e to
35d3929
Compare
…ng change Signed-off-by: Clovis Durand <[email protected]>
Clovel
force-pushed
the
feature/config-path
branch
from
35d3929 to
e3a6eb4
Compare
Clovel
changed the title
|
i would say duplicate of #142 |
It is, but the commits are signed-off and GPG signed. I understand that that's a requirement for PRs to be accepted here so I took the liberty of doing it again with signed commits. Also ran a lot of tests with my version of the chart in staging and production. |
|
Thanks for the hint that commits must be signed-off with a GPG key now :) i use my fork also since several weeks in our production env, but I'm also fine to continue with your PR. |
joshsizer
approved these changes
Jun 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #135