Use labels suggested by K8s and Helm best practices #173
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I like what this does but do have to ask. Why does it need to be a breaking change? can the labels not co-exist for a time and a deprecation notice be given? |
Sure they can, NP here. updated |
Many tools can benefit from using those labels, providing either extra information or simplifying life of many by unifying the labels zoo.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This improves the compatibility and makes it easier to work with various tools, which take advantage from the assumption of existence of those labels.
Changing the selectors is breaking change, so the bump of the major version of the helm chart.