feat: fix critical security vulnerabilities and update dependencies #16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGE: The minifyHtml function is now async and returns Promise<string> Security fixes: - Replace [email protected] with [email protected] (fixes GHSA-pfq8-rq6v-vf5m REDoS vulnerability) - Replace [email protected] with secure custom template implementation (fixes GHSA-35jh-r3h4-6jhm command injection) - Fix @octokit dependency vulnerabilities via npm overrides - Update brace-expansion to fix ReDoS vulnerability Breaking changes: - html.minifyHtml() now returns Promise<string> instead of string - Must await minifyHtml() function calls - Custom template implementation replaces lodash.template (same API, safer execution) Migration: Update minifyHtml usage from sync to async: Before: const result = minifyHtml(html, options); After: const result = await minifyHtml(html, options); Version bump: 3.1.1 → 3.2.0
DRiFTy17
reviewed
Jul 22, 2025
| @@ -1,3 +1,4 @@ | |||
|
|
|||
There was a problem hiding this comment.
I don't think it'll mess with the changelog generator, but might as well just remove the unrelated line change here
…changes - Remove unused templateOptions parameter from templateFile and installFiles functions - Revert .gitignore changes to allow team to add official CLAUDE.md guidance - Clean up function signatures to match actual usage patterns
DRiFTy17
approved these changes
Jul 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Changes
Testing