-
Notifications
You must be signed in to change notification settings - Fork 557
Add withXXX methods for easy IORuntime configuration #3192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add withXXX methods for easy IORuntime configuration #3192
Conversation
@armanbilge how about this? Also I don't know why CI didn't run... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the long run I think IORuntimeConfig
needs to no longer be a case class
, because otherwise we are paying the cost of public copy
s and with
methods.
Is this really better than just using |
Yes, if we de-case-classify |
Right but if we keep |
Which is terrible for bincompat :) For example Indeed, I suspect we've already broken it and our over-aggressive filters are just not telling us. |
Hmm, I take that back. I guess the mirrors can evolve bincompatibly without intervention (edit: although they may throw runtime errors 🤔 ). Also I am concerned about the |
Sorry to only just get to this. Where did we land with this? Shall I just close it? |
Okay coming back to this… (finally) I think let's close this for now. If we un-case-class-ify |
No description provided.