Fix Sponsor Duplicates #4729
Merged
Fix Sponsor Duplicates #4729
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add breaks - sort sponsors by level and only add the first one
valencik
previously approved these changes
Mar 8, 2025
Co-authored-by: Andrew Valencik <[email protected]>
valencik
approved these changes
Mar 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4663
There were actually 2 issues. Some sponsors were duplicated, with and without a tier in the GraphQL response. The switch was also falling through due to lack of breaks. I added code to sort by level + name, then only add a sponsor the first time they are seen.
Testing locally, we can see Aruna now only appears in Gold, and Silver sponsors are no longer duplicated to backers. @jducoeur is no longer duplicated in other contributors.