Skip to content

Fix some warnings related to -xsource:3 #890

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 5, 2025
Merged

Fix some warnings related to -xsource:3 #890

merged 3 commits into from
Mar 5, 2025

Conversation

morgen-peschke
Copy link
Contributor

Fixes #889

@morgen-peschke morgen-peschke requested review from danicheg, samspills and a team February 13, 2025 19:01
rossabaker
rossabaker approved these changes Feb 19, 2025
View reviewed changes
Copy link
Member

@rossabaker rossabaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I admit I've lost all track of what syntax is in and out of fashion anymore. The build passes and I'm not offended by anything, so, ✅

bcarter97
bcarter97 reviewed Feb 20, 2025
View reviewed changes
@morgen-peschke morgen-peschke requested a review from bcarter97 March 4, 2025 19:56
@morgen-peschke morgen-peschke merged commit 1b34000 into typelevel:main Mar 5, 2025
14 checks passed
@morgen-peschke morgen-peschke deleted the normalize-wildcards branch March 5, 2025 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rossabaker rossabaker rossabaker approved these changes

@samspills samspills samspills approved these changes

@bcarter97 bcarter97 bcarter97 approved these changes

@danicheg danicheg Awaiting requested review from danicheg

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix style inconsistencies
4 participants
@morgen-peschke @rossabaker @samspills @bcarter97