Activate child spans just like root spans #1186
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Activation binds span to current thread via ThreadLocal so it will become incorrect when IO/Fiber switches threads but at least it's an improvement and consistent with root spans. Ideally there would be a Span option to disable activation entirely.
mwisnicki
commented
Jun 23, 2025
| @@ -74,6 +74,9 @@ final case class DDSpan[F[_]: Sync]( | |||
| case (span, ExitCase.Errored(e)) => Sync[F].delay(span.log(e.toString).finish()) | |||
| case (span, _) => Sync[F].delay(span.finish()) | |||
| } | |||
| .flatTap(span => | |||
| Resource.make(Sync[F].delay(tracer.activateSpan(span)))(s => Sync[F].delay(s.close())) | |||
| ) | |||
There was a problem hiding this comment.
Copied from
natchez/modules/datadog/src/main/scala/DDEntryPoint.scala
Lines 28 to 30 in 64c292d
1 task
kubukoz
approved these changes
Jun 23, 2025
|
As per #1187 (comment) I now think that the right thing to do here is to never activate span since it is likely useless unless used as in #1189 |
|
Obsoleted by #1191 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DDEntryPointactivates created spans soDDSpanshould too.Activation binds span to current thread via ThreadLocal so it will become incorrect when IO/Fiber switches threads but at least it's an improvement and consistent with root spans.
Ideally there would be a Span option to disable activation entirely like this: #1187