Fix bug where WebSocket's close wasn't sent to client#14
Open
edvakf wants to merge 1 commit intotypester:masterfrom
Open
Fix bug where WebSocket's close wasn't sent to client#14edvakf wants to merge 1 commit intotypester:masterfrom
edvakf wants to merge 1 commit intotypester:masterfrom
Conversation
Owner
|
Can you provide some html+javascript samples that reproduce this issue? |
Author
|
An echo server example. https://github.com/edvakf/go-websocket-sample Type "bye" and hit enter to make the server close the connection. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
At the moment, gate keeps holding the connection when the server closes a WebSocket connection through gate. Therefore,
oncloseof JavaScript's WebSocket object never gets called.To be honest, I'm not too sure why this patch solves the problem... but I got it from studying another WebSocket proxy.
https://github.com/joinmytalk/drunken-hipster/blob/master/main.go#L49-L65