Sort members of codex::ROOT
#8
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
There is no release available on crates.io for now (0.0.1 is empty I believe). |
MDLC01
approved these changes
Nov 19, 2024
laurmaedje
approved these changes
Nov 26, 2024
Member
|
Definitely a major oversight on my part! Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a bit of a 'how did we not catch this earlier?' story, but in all fairness this repository is only 5 days old.
I was checking out the Rust API when I noticed
ROOT.get("sym")returnedNone—after which I came to realiseROOT's members weren't sorted in key-order, meaning thebinary_search_by_keycall didn't uphold its preconditions :PI simply swapped the order of
SYMandEMOJIinROOT's definition and added a test to ensure all modules remain sorted indefinitely.@laurmaedje I do think this fix warrants a new release to crates.io, this was a slightly major bug.