Open
Conversation
MDLC01
reviewed
Nov 20, 2024
Collaborator
|
This would close #6, right? |
Collaborator
Author
|
Yeah, that's the idea |
Member
|
I think it might be a little cleaner to have a new feature |
Collaborator
|
I think it may be more future-proof to force the name to be quoted (alternative A. in OP), as suggested in #2 (comment). |
Collaborator
|
@emilyyyylime are you still willing to work on this PR, or should we close it for now? |
Collaborator
Author
|
Yeah, I can implement the feature name and quoting + resolve conflicts |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is locked behind an optional build dependency to avoid incurring the cost of
unicode_names2to every downstream package. (It really is much heavier than it needs to be 😅)To reiterate; this PR does not amount to any extra build time or dependencies for downstream packages (unless they explicitly opt in to the
unicode_names2feature.)The current syntax consist of simply appending the name after the U+XXXX literal, some alternatives that were discussed:
///or//!)Also as the code is implemented currently, explicit names cannot be added after verbatim characters. This was mostly an arbitrary choice and might be rethought if we decide on implementing one of the other syntax options above.
Another area with some room to behave differently is this being a build dependency, rather than a dev-dependency. This was done because writing the verification as a separate test would require reimplementation of the parsing code from the ground up (dev-dependencies are only available inside tests/benchmarking code).
Example output for bad names: