-
-
Notifications
You must be signed in to change notification settings - Fork 12
Fix docs #96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
T0mstone
wants to merge
4
commits into
typst:main
Choose a base branch
from
T0mstone:fix-docs
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Fix docs #96
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The only change is "single character" -> "string", it's just obscured by having to re-wrap the text.
I'd say this is meta but doesn't require Laurenz's approval since this is a minor documentation change. |
MDLC01
approved these changes
Jul 3, 2025
Enivex
reviewed
Jul 3, 2025
Found another small oversight that I've just lumped in this PR. Technically not documentation, but an assertion error message is close enough imo. |
mkorje
previously approved these changes
Jul 4, 2025
mkorje
reviewed
Jul 4, 2025
mkorje
approved these changes
Jul 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These were slightly out of date after #92.
I've also taken the liberty to rephrase them a bit; Ever since #46, the crate-level docs have explained what a variant is, so we can just use that word in the functions' docs.
(Not sure whether this counts as meta or not)