Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clean-dhbw:0.1.0 #1556

Merged
merged 6 commits into from
Jan 14, 2025
Merged

clean-dhbw:0.1.0 #1556

merged 6 commits into from
Jan 14, 2025

Conversation

roland-KA
Copy link
Contributor

@roland-KA roland-KA commented Jan 12, 2025

I am submitting

  • a new package
  • an update for a package

This is a (modernized) Typst template for DHBW documents like Bachelor theses, "Studienarbeiten", project documentation etc. and thus may be useful for all DHBW students.

I have read and followed the submission guidelines and, in particular, I

  • [ x] selected a name that isn't the most obvious or canonical name for what the package does
  • [ x] added a typst.toml file with all required keys
  • [x ] added a README.md with documentation for my package
  • [x ] have chosen a license and added a LICENSE file or linked one in my README.md
  • [x ] tested my package locally on my system and it worked
  • [ x] excluded PDFs or README images, if any, but not the LICENSE
  • [ x] ensured that my package is licensed such that users can use and distribute the contents of its template directory without restriction, after modifying them through normal use.

@roland-KA
Copy link
Contributor Author

I need some help with this PR. Why did the check for the PR fail?

@elegaanz elegaanz added the new A new package submission. label Jan 12, 2025
@elegaanz
Copy link
Member

You should put your code in a 0.1.0 sub-folder, not directly in preview/clean-dhbw.

@roland-KA
Copy link
Contributor Author

Oh, I see, thanks!

@typst-package-check typst-package-check bot changed the title clean-dhbw-template 0.1.0 clean-dhbw:0.1.0 Jan 12, 2025
@roland-KA
Copy link
Contributor Author

The warnings which now remain, occur in an external package codelst (which is used to display code snippets within the body text) on which I don't have any influence. Overmore this package is only an option to use within the template. So I would suggest to let the PR pass.

@elegaanz
Copy link
Member

Version 2.0.2 of codelst should fix these warnings, can you please update it?

@roland-KA
Copy link
Contributor Author

Done! ... and thanks for the hint!

@elegaanz
Copy link
Member

Thanks!

@elegaanz elegaanz merged commit 644101f into typst:main Jan 14, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new A new package submission.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants