Add multi db support for migrations #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ciebiada
reviewed
Mar 14, 2025
MikolajSiwek
requested review from
swiatek,
czereba and
Ciebiada
and removed request for
swiatek
Ciebiada
approved these changes
Mar 24, 2025
czereba
approved these changes
Mar 25, 2025
step as schema updates will be passed in a PR's, update README
MikolajSiwek
commented
Jun 26, 2025
| migrator(migration.version).run | ||
| end | ||
|
|
||
| Rake::Task["db:schema:dump"].invoke if ActiveRecord::Base.schema_format == :ruby |
There was a problem hiding this comment.
@czereba @Ciebiada to bodajże to miejsce odpowiedzialne za tworzenie schema.
Z tego co pamiętam to usuneliśmy to, bo stwierdziliśmy że tego gema używamy i tak głównie przy deploymencie a wtedy schema już jest zupdatowana bo puszczamy migrację normalnie lokalnie updatując wtedy scheme 🤔
(Jest w PR już zupdatowana)
Jak są railsy to pewnie można używać railsowej komendy do migracji i ona nie używa gema ... ale dla projektów quasi rails hmm pewnie trzeba by użyć bundle exec rake db:migrate i wtedy wszystko się powinno zadziać okay ... bo tutaj puszczając lokalnie pewnie nie musimy puszczać w grupie? 🤔
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Grouping for migrations in a multi database environment was not working correctly as this gem does not support that Rails 6+ feature. Handling multidb envs was added to this version of the gem.
How Has This Been Tested?
Tested locally on socialguide and mjollnir
Please describe how you tested your changes,
see how your change affects other areas of the code, etc.
Pull Request Checklist
Change Management
https://issues.talkwalker.net/issue/SCR-7023