Skip to content

added service specific ciphers #90

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions dlms_cosem/connection.py
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,15 @@ class XDlmsApduFactory:
196: xdlms.GetResponseFactory,
197: xdlms.SetResponseFactory,
199: xdlms.ActionResponseFactory,

# Service Specific Global Ciphering
200: xdlms.GlobalGetRequest,
201: xdlms.GlobalSetRequest,
202: xdlms.GlobalActionNotificationRequest,
203: xdlms.GlobalActionRequest,
204: xdlms.GlobalGetResponse,
205: xdlms.GlobalSetResponse,
207: xdlms.GlobalActionResponse,
}

@classmethod
Expand Down
9 changes: 9 additions & 0 deletions dlms_cosem/protocol/xdlms/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,15 @@
GlobalCipherInitiateResponse,
InitiateResponse,
)
from dlms_cosem.protocol.xdlms.service_specific_cipher import (
GlobalGetRequest,
GlobalSetRequest,
GlobalActionNotificationRequest,
GlobalActionRequest,
GlobalGetResponse,
GlobalSetResponse,
GlobalActionResponse,
)
from dlms_cosem.protocol.xdlms.invoke_id_and_priority import InvokeIdAndPriority
from dlms_cosem.protocol.xdlms.set import (
SetRequestFactory,
Expand Down
46 changes: 46 additions & 0 deletions dlms_cosem/protocol/xdlms/service_specific_cipher.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,46 @@
import attr
from typing import *
from dlms_cosem.protocol.xdlms.base import AbstractXDlmsApdu
from dlms_cosem.protocol.xdlms.initiate_request import GlobalCipherInitiateRequest


ServiceSpecificCipher = type(
"ServiceSpecificCipher",
(AbstractXDlmsApdu,),
dict(GlobalCipherInitiateRequest.__dict__),
)


@attr.s(auto_attribs=True)
class GlobalGetRequest(ServiceSpecificCipher):
TAG: ClassVar[int] = 200


@attr.s(auto_attribs=True)
class GlobalSetRequest(ServiceSpecificCipher):
TAG: ClassVar[int] = 201


@attr.s(auto_attribs=True)
class GlobalActionNotificationRequest(ServiceSpecificCipher):
TAG: ClassVar[int] = 202


@attr.s(auto_attribs=True)
class GlobalActionRequest(ServiceSpecificCipher):
TAG: ClassVar[int] = 203


@attr.s(auto_attribs=True)
class GlobalGetResponse(ServiceSpecificCipher):
TAG: ClassVar[int] = 204


@attr.s(auto_attribs=True)
class GlobalSetResponse(ServiceSpecificCipher):
TAG: ClassVar[int] = 205


@attr.s(auto_attribs=True)
class GlobalActionResponse(ServiceSpecificCipher):
TAG: ClassVar[int] = 207
26 changes: 26 additions & 0 deletions tests/test_xdlms/test_service_specific_cipher.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,26 @@
from dlms_cosem import security
from dlms_cosem.protocol import xdlms


# TODO: move GlobalCipherInitiateRequest here
def test_glo_get_request():
"""
Example extracted from
Table 40 – Example: glo-get-request xDLMS APDU
"""
parsed = xdlms.GlobalGetRequest(
security_control=security.SecurityControlField(
encrypted=True, authenticated=True, security_suite=0
),
invocation_counter=int.from_bytes(bytes.fromhex("01234567"), "big"),
ciphered_text=bytes.fromhex(
"411312FF935A4756 6827C467BC" # encrypted
"7D825C3BE4A77C3F CC056B6B" # authentication tag
),
)

raw = bytes.fromhex(
"C81E300123456741" "1312FF935A475668" "27C467BC7D825C3B" "E4A77C3FCC056B6B"
)
assert parsed == xdlms.GlobalGetRequest.from_bytes(raw)
assert raw == parsed.to_bytes()