fix: add regex patterns for Baidu Explorer #616
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lbarthon
reviewed
Jun 11, 2025
regexes.yaml
Outdated
| @@ -448,6 +448,10 @@ user_agent_parsers: | |||
| family_replacement: 'Baidu Browser' | |||
| - regex: '(FlyFlow)/(\d+)\.(\d+)' | |||
| family_replacement: 'Baidu Explorer' | |||
| - regex: '(flyflow)/(\d+)\.(\d+)\.(\d+)\.(\d+)' | |||
| family_replacement: 'Baidu Explorer' | |||
| - regex: '(baiduboxapp)/(\d+)\.(\d+)\.(\d+)\.(\d+)' | |||
There was a problem hiding this comment.
does it need to be so high in the parsing? can it be merged in one regex?
welkinwong
force-pushed
the
fix-baidu-browser
branch
from
2d854a5 to
46aaef1
Compare
|
@lbarthon Thanks for the review! I've merged the regex patterns as suggested and grouped them with QQ Browser since they share similar characteristics. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supplement ua regular expressions and test cases for Baidu Explorer