Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing include for integer types (needed for GCC 13) #39

Merged
merged 1 commit into from
Apr 9, 2025

Conversation

DailyMats
Copy link
Contributor

The current master does not build on Ubuntu 23.10:

root@df7042aa9f8f:/uap-cpp# make
g++ -c  -std=c++0x -Wall -Werror -g -fPIC -O3 UaParser.cpp -o UaParser.o
g++ -c  -std=c++0x -Wall -Werror -g -fPIC -O3 internal/Pattern.cpp -o internal/Pattern.o
g++ -c  -std=c++0x -Wall -Werror -g -fPIC -O3 internal/AlternativeExpander.cpp -o internal/AlternativeExpander.o
g++ -c  -std=c++0x -Wall -Werror -g -fPIC -O3 internal/SnippetIndex.cpp -o internal/SnippetIndex.o
In file included from internal/SnippetIndex.cpp:1:
internal/SnippetIndex.h:22:11: error: 'uint32_t' does not name a type
   22 |   typedef uint32_t SnippetId;
      |           ^~~~~~~~
internal/SnippetIndex.h:9:1: note: 'uint32_t' is defined in header '<cstdint>'; did you forget to '#include <cstdint>'?
    8 | #include <vector>
  +++ |+#include <cstdint>
    9 |

This PR adds the missing includes.

@prm-james-hill
Copy link

Hitting the same issue. Not sure who has write access to this repo. @asuhan ?

@asuhan asuhan merged commit 906762b into ua-parser:master Apr 9, 2025
@asuhan
Copy link
Collaborator

asuhan commented Apr 9, 2025

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants