Skip to content

Conversation

@fatimarabab
Copy link
Collaborator

Pull Request Template

Checklist before requesting a review

  • I have performed a self-review of my code.
  • My code follows the style guidelines enforced by static analysis tools.
  • If it is a core feature, I have added thorough tests.
  • My changes generate no new warnings.
  • New and existing unit tests pass locally with my changes.
  • New or existing JSON is formatted using JQ
  • I have updated the CHANGELOG to note of any product updates that will be going in with this pull request.

Pull Request Details

Wrike ticket - Refactor Analysis View Menu to incorporate Linking
Changes made:

  • Updated the Action Menu in Analysis View to include menu items - Link Unit, Logout
  • Updated tests.

To Review:

  • Static Analysis by Reviewer

  • The changes made to update the analysis view action menu are working as rendered correctly.
    To check this run the following commands:

    < Recommended command (s) provided here, modify as needed. >
    ....
    docker compose down
    docker system prune -a --volumes
    docker compose up --build -d
  • All tests pass.

  • All Github Actions checks have passed.

Screenshots (if appropriate)

Screenshot 2026-01-20 at 3 43 11 PM

@fatimarabab fatimarabab self-assigned this Jan 20, 2026
@fatimarabab fatimarabab added the enhancement New feature or request label Jan 20, 2026
@SeriousHorncat
Copy link
Collaborator

image Menu rendering!

Copy link
Collaborator

@SeriousHorncat SeriousHorncat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Looks great. There is only one thing before pulling this into main. Since it is including the linkOmicUnitOption to be included in main but the feature isn't available yet, could one of the following be done?

  1. In the action menu, disable the option making it unavailable? (this can be hard-coded and removed when the feature is complete)
  2. remove the option from the action menu; since the PR demonstrated it can be added with just a single line, that is sufficient enough for me that it works!

I like the idea of the first one, since it will serve as a preview of the upcoming feature if we have to go ahead and release sooner then we planned.

@fatimarabab
Copy link
Collaborator Author

PR Looks great. There is only one thing before pulling this into main. Since it is including the linkOmicUnitOption to be included in main but the feature isn't available yet, could one of the following be done?

  1. In the action menu, disable the option making it unavailable? (this can be hard-coded and removed when the feature is complete)
  2. remove the option from the action menu; since the PR demonstrated it can be added with just a single line, that is sufficient enough for me that it works!

I like the idea of the first one, since it will serve as a preview of the upcoming feature if we have to go ahead and release sooner then we planned.

Discussed in stand up to keep this branch as a feature branch for Linking 'omic units, and merge it as a completed feature into main.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants