Modify/improve MadsTEMDriver.observed_vec function, fix bug. #741
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds the capability for the observed_vec function to return either a labeled array or flat list of target (observation) values. Turns out that the labeled array was helpful for testing/cross checking the order of the flat list. Adds tests that go with the new feature. Fixes bug with indentation of return statement in observed_vec function. Change AC-MADS-TEM.jl so that it explicitly requests a flat list as the remainder of MADS seems to expect.
Messed up the single vs double quotes for julia strings...
Pushed a fix changing " -> ' in AC-MADS-TEM.jl, though tcarman, had already fixed this. It should be the opposite ' -> "
I have added a suggested fix for the outlabels bug in comments above the current break point, this does not fully work but may have some syntax that will be useful.
…r the tests. This is sort of confusing - in the process of re-arranging the way that testing data is stored and handled (see pull request and branch removing GitLFS). But the ideas is that the demo data should come with the repo and the testing data will require an extra step (details yet to be determined) for the user to acquire.
Adding test for when only soil params are specified
Problems with axes labeling. Start by setting label rotation to 90 to accomodate longer labels, and re-organize funciton to group commands for each axes together.
Looks like this should have only handled axes 1 and 2 because they have the same x scale, while axes 0 is different.
...subtle changes in printing DataFrame
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the capability for the observed_vec function to return either a labeled array or flat list of target (observation) values. Turns out that the labeled array was helpful for testing/cross checking the order of the flat list.
Adds tests that go with the new feature.
Fixes bug with indentation of return statement in observed_vec function.
Change AC-MADS-TEM.jl so that it explicitly requests a flat list as the remainder of MADS seems to expect.