Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing notices/warnings for PHP 5.6 #172

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Fixing notices/warnings for PHP 5.6 #172

wants to merge 3 commits into from

Conversation

BrendonKoz
Copy link

I fixed any/all warnings and notices that I discovered running the current master under PHP 5.6 (with CakePHP debug set to 2).

This is just the start of the effort to properly upgrade compatibility to Cake PHP v2.8 (minimum) for PHP7 compatibility.

Fixed PHP notice level errors
Fixed compatibility errors up to PHP 5.6
Updated Tags plugin to current version
Fixed all errors that were being displayed with regard to PHP v5.6. Cleaned up some syntax inconsistencies in various files.
@michaelhagedon
Copy link
Member

Thanks so much, @BrendonKoz! We'll take a look.

@BrendonKoz
Copy link
Author

There are a lot of unnecessary text changes that have been made due to my editor (sorry). I just noticed that changes to app/Config/core.php was unfortunately not ignored like I thought it was -- Cake::Configure's debug value should not be changed to 2 for others. (Unrelated: Having issues with JavaScript-related processes in further upgrade path, thus the lack of additional progress.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants